Skip to content

Conversation

@shushanhf
Copy link
Contributor

@shushanhf shushanhf commented Apr 23, 2023

This PR is part of the issue #69705 to amend the LA's port.

Fix the reverse of genCodeForJumpCompare for LoongArch64 and RISCV64.

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Apr 23, 2023
@ghost
Copy link

ghost commented Apr 23, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is part of the issue #69705 to amend the LA's port.

fix the genCodeForJumpCompare for reverse.

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@shushanhf shushanhf changed the title [LoongArch64] fix the genCodeForJumpCompare for reverse. Fix the reverse of genCodeForJumpCompare for LoongArch64 and RISCV64. Apr 24, 2023
@shushanhf
Copy link
Contributor Author

@clamp03
I had tested the LoongArch64 is OK.
As I don't have RISCV64, I think this PR is value for RISCV64.

@shushanhf
Copy link
Contributor Author

Hi, @jakobbotsch
Could you please review this PR?

@clamp03
Copy link
Member

clamp03 commented Apr 24, 2023

As I don't have RISCV64, I think this PR is value for RISCV64.

@shushanhf Thank you very much. It is valuable for RISC-V as well. Actually, just CC me would have been a big help to me. I'd just like to ask you (if you don't mind) to add RISC-V such simple fixes to as #85216 from next time. I really appreciate your work.
I know you don't have to test patches on RISC-V at all. Just include me in the patch. I will!!!
In fact, I cannot even imagine starting the RISC-V port without your work. Thanks again.

@shushanhf
Copy link
Contributor Author

As I don't have RISCV64, I think this PR is value for RISCV64.

@shushanhf Thank you very much. It is valuable for RISC-V as well. Actually, just CC me would have been a big help to me. I'd just like to ask you (if you don't mind) to add RISC-V such simple fixes to as #85216 from next time. I really appreciate your work. I know you don't have to test patches on RISC-V at all. Just include me in the patch. I will!!! In fact, I cannot even imagine starting the RISC-V port without your work. Thanks again.

I didn't modify the RISC-V at some time just because I can‘t test RISC-V liking the LoongArch64.

@shushanhf
Copy link
Contributor Author

As #85242 refactor

@shushanhf shushanhf closed this Apr 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
@shushanhf shushanhf deleted the jump_compare branch June 5, 2023 01:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants