Skip to content

Conversation

@shushanhf
Copy link
Contributor

@shushanhf shushanhf commented Apr 23, 2023

This PR is part of the issue #69705 to amend the LA's port.

Fix compiling errors within LoongArch64 and RISCV64 for ins_Move_Extend.

As RISCV64 #85232 is just a duplication of this PR, addding RISCV64 also.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Apr 23, 2023
@ghost
Copy link

ghost commented Apr 23, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is part of the issue #69705 to amend the LA's port.

fix compiling errors for inst_Mov_Extend and ins_Move_Extend.

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@shushanhf shushanhf force-pushed the compiling_errors branch 2 times, most recently from d079032 to 2c3cfe3 Compare April 23, 2023 08:11
@shushanhf shushanhf changed the title [LoongArch64] fix compiling errors for inst_Mov_Extend and ins_Move_Extend. [LoongArch64] fix compiling errors for ins_Move_Extend. Apr 23, 2023
@shushanhf
Copy link
Contributor Author

Hi, @jakobbotsch
Could you please review this PR?
Thanks

@shushanhf shushanhf changed the title [LoongArch64] fix compiling errors for ins_Move_Extend. Fix compiling errors within LoongArch64 and RISCV64 for ins_Move_Extend. Apr 24, 2023
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the break, thought I had validated things were compiling for LOONGARCH64 and RISC-V.

@jakobbotsch jakobbotsch merged commit c45caed into dotnet:main Apr 24, 2023
@shushanhf shushanhf deleted the compiling_errors branch April 24, 2023 11:16
@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants