Skip to content

AOT Runtime.Base: Change AttributeTargets and AttributeUsageAttribute to public #76573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 2 commits into from
Oct 4, 2022
Merged

AOT Runtime.Base: Change AttributeTargets and AttributeUsageAttribute to public #76573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5ea087
Change nativeaot attribute types to public
cston Oct 3, 2022
93b846a
Remove noRefSafetyRulesAttribute
cston Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/nativeaot/Runtime.Base/src/System/AttributeTargets.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace System
// Enum used to indicate all the elements of the
// VOS it is valid to attach this element to.

internal enum AttributeTargets
public enum AttributeTargets
{
Assembly = 0x0001,
Module = 0x0002,
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/nativeaot/Runtime.Base/src/System/AttributeUsageAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace System
{
/* By default, attributes are inherited and multiple attributes are not allowed */
[AttributeUsage(AttributeTargets.Class, Inherited = true)]
internal sealed class AttributeUsageAttribute : Attribute
public sealed class AttributeUsageAttribute : Attribute
{
//Constructors
public AttributeUsageAttribute(AttributeTargets validOn)
Expand Down
1 change: 0 additions & 1 deletion ...r.Compiler.Tests/ILCompiler.Compiler.Tests.Assets/ILCompiler.Compiler.Tests.Assets.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
<TargetFramework>netstandard2.0</TargetFramework>
<!-- Don't add references to the netstandard platform since this is a core assembly -->
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
<Features>noRefSafetyRulesAttribute=true</Features>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/tools/aot/ILCompiler.Compiler.Tests/ILCompiler.Compiler.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<Platforms>x86;x64</Platforms>
<PlatformTarget>AnyCPU</PlatformTarget>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<Features>noRefSafetyRulesAttribute=true</Features>
</PropertyGroup>

<ItemGroup>
Expand Down