Skip to content

Conversation

@cston
Copy link
Contributor

@cston cston commented Oct 3, 2022

AttributeTargets and AttributeUsageAttribute must be public to allow the C# compiler to emit [module: RefSafetyRules] successfully.

See #76459 (comment).

@ghost ghost assigned cston Oct 3, 2022
@cston cston marked this pull request as ready for review October 3, 2022 23:26
@cston
Copy link
Contributor Author

cston commented Oct 3, 2022

cc @jaredpar, @stephentoub

@jkotas
Copy link
Member

jkotas commented Oct 4, 2022

Tools unit tests passed.

@jkotas jkotas merged commit ad7f31d into dotnet:main Oct 4, 2022
@cston cston deleted the nativeaot-attribute-types branch October 4, 2022 03:58
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants