Skip to content

Revert "Temporarily disable coredumps during library testing on macOS (#63742)" #64057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 1 commit into from
Jan 20, 2022
Merged

Revert "Temporarily disable coredumps during library testing on macOS (#63742)" #64057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eng/testing/RunnerTemplate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,7 @@ if [[ "$(uname -s)" == "Darwin" ]]; then
# files already in /cores/ at this point. This is being done to prevent
# inadvertently flooding the CI machines with dumps.
if [[ ! -d "/cores" || ! "$(ls -A /cores)" ]]; then
# FIXME: temporarily disable core dumps
ulimit -c 0
ulimit -c unlimited
fi

elif [[ "$(uname -s)" == "Linux" ]]; then
Expand Down