Skip to content

Make test System.Data.Tests.AppDomainsAndFormatInfo.Bug55978 more robust #63028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maraf merged 2 commits into from
Jan 12, 2022
Merged

Make test System.Data.Tests.AppDomainsAndFormatInfo.Bug55978 more robust #63028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4af47eb
Add explicit 1 minute difference to all datetimes in rows.
maraf Dec 20, 2021
789fdad
Remove active issue.
maraf Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/libraries/System.Data.Common/tests/System/Data/DataTableTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3566,34 +3566,38 @@ public void Remote()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/62965", TestPlatforms.Browser)] // fails on NodeJS on windows
public void Bug55978()
{
DataTable dt = new DataTable();
dt.Columns.Add("StartDate", typeof(DateTime));

DataRow dr;
DateTime date = DateTime.Now;
DateTime now = DateTime.Now;

// In RowFilter we have a string containing only seconds,
// but in rows we have a DateTime which also contains milliseconds.
// The test would fail without this extra minute, when now.Millisecond is 0.
DateTime rowDate = now.AddMinutes(1);

for (int i = 0; i < 10; i++)
{
dr = dt.NewRow();
dr["StartDate"] = date.AddDays(i);
dr["StartDate"] = rowDate.AddDays(i);
dt.Rows.Add(dr);
}

DataView dv = dt.DefaultView;
dv.RowFilter = string.Format(CultureInfo.InvariantCulture,
"StartDate >= #{0}# and StartDate <= #{1}#",
DateTime.Now.AddDays(2),
DateTime.Now.AddDays(4));
now.AddDays(2),
now.AddDays(4));
Assert.Equal(10, dt.Rows.Count);

int expectedRowCount = 2;
if (dv.Count != expectedRowCount)
{
StringBuilder sb = new();
sb.AppendLine($"DataView.Rows.Count: Expected: {expectedRowCount}, Actual: {dv.Count}. Debug data: RowFilter: {dv.RowFilter}, date: {date}");
sb.AppendLine($"DataView.Rows.Count: Expected: {expectedRowCount}, Actual: {dv.Count}. Debug data: RowFilter: {dv.RowFilter}, date: {now}");
for (int i = 0; i < dv.Count; i++)
{
sb.Append($"row#{i}: ");
Expand Down