setInternalRegsDelayFree only for candidate lclVars #62884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIn #58914 , we partially fixed the #58899, but it should have taken into account it only for candidate lclVars. Without this, we would end up having a Fixes: #61579
|
Contributor
Author
|
/azp list |
Contributor
Author
|
/azp run runtime-coreclr jitstress-isas-x86 |
Contributor
Author
|
/azp run runtime-coreclr jitstressregs-x86 |
Contributor
Author
|
/azp run runtime-coreclr jitstress-isas-arm |
Contributor
Author
|
/azp run runtime-coreclr jitstressregs |
Contributor
Author
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@dotnet/jit-contrib |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Dec 16, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #58914 , we partially fixed the #58899, but it should have taken into account it only for candidate lclVars. Without this, we would end up having a
delayFreeon last use and when we see the new refposition, we would assert because there was a pendingdelayRegFreewithout reference.Fixes: #61579