Skip to content

Conversation

@josalem
Copy link
Contributor

@josalem josalem commented Aug 31, 2021

No description provided.

@josalem josalem added area-System.Diagnostics.Tracing test-enhancement Improvements of test source code labels Aug 31, 2021
@josalem josalem added this to the 6.0.0 milestone Aug 31, 2021
@josalem josalem requested a review from danmoseley August 31, 2021 23:54
@josalem josalem self-assigned this Aug 31, 2021
@ghost
Copy link

ghost commented Aug 31, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: josalem
Assignees: josalem
Labels:

area-System.Diagnostics.Tracing, test enhancement

Milestone: 6.0.0

@ghost
Copy link

ghost commented Sep 1, 2021

Hello @josalem!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 19392ab into dotnet:main Sep 1, 2021
@danmoseley
Copy link
Member

Another option we've used in some tests, and we could build into RemoteExecutor, is to have the test continue past the timeout before it fails, so it can tell us how long it ultimately took (or whether it effectively hung).

Eg timeout of 1 minute. Test takes 1:30. Test fails because it took over 1 minute, but logs 1:30 in the failure so we know it was merely slow. We might chose to raise the timeout rather than investigate.

@danmoseley
Copy link
Member

Actually it would probably make sense to modify RemoteExecutor do so this automatically, waiting up to eg 2x the specified timeout or 10 minutes whichever is less. That would give us good info from time to time including in this case.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants