Skip to content

Disable iOS ARM validation #51481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmitche merged 4 commits into from
Apr 20, 2021
Merged

Disable iOS ARM validation #51481

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c23a15d
Disable iOS ARM validation
lukas-lansky Apr 19, 2021
1f37e15
skip SslStream_ClientCertificate_SendsChain test if chain is not vali…
wfurt Feb 13, 2021
cc68235
Disable iOS ARM validation further
lukas-lansky Apr 19, 2021
026fb56
Code review feedback: Disable also iOS/tvOS/Android
lukas-lansky Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions eng/pipelines/runtime-official.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,17 @@ stages:
- tvOS_arm64
- iOS_x64
- iOS_x86
- iOS_arm
- iOS_arm64
- OSX_x64
- Linux_x64
- Linux_arm
- Linux_arm64
- Linux_musl_x64
- Browser_wasm

# https://github.com/dotnet/runtime/pull/50940
# - iOS_arm
# - iOS_arm64

# - Linux_musl_arm
# - Linux_musl_arm64
# - Windows_NT_x64 enable once coreclr.dll has a version header: https://github.com/dotnet/runtime/issues/37503
Expand Down
8 changes: 6 additions & 2 deletions eng/pipelines/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,11 @@ jobs:
- Android_x86
- Android_arm64
- tvOS_x64
- iOS_arm64
- iOS_x86
- Linux_arm

# https://github.com/dotnet/runtime/pull/50940
# - iOS_arm64
jobParameters:
testGroup: innerloop
nameSuffix: AllSubsets_Mono
Expand All @@ -289,9 +291,11 @@ jobs:
- Android_x64
- Android_arm
- tvOS_arm64
- iOS_arm
- iOS_x64
- Linux_musl_x64

# https://github.com/dotnet/runtime/pull/50940
# - iOS_arm
jobParameters:
testGroup: innerloop
nameSuffix: AllSubsets_Mono
Expand Down
7 changes: 5 additions & 2 deletions src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamNetworkStreamTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ public async Task SslStream_UntrustedCaWithCustomCallback_Throws(bool customCall
}
}

[Fact]
[ConditionalFact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/46837", TestPlatforms.OSX)]
public async Task SslStream_ClientCertificate_SendsChain()
{
Expand Down Expand Up @@ -434,7 +434,10 @@ public async Task SslStream_ClientCertificate_SendsChain()
}

// Verify we can construct full chain
Assert.True(chain.ChainElements.Count > clientChain.Count, "chain cannot be built");
if (chain.ChainElements.Count < clientChain.Count)
{
throw new SkipTestException($"chain cannot be built {chain.ChainElements.Count}");
}
}

var clientOptions = new SslClientAuthenticationOptions() { TargetHost = "localhost", };
Expand Down