Skip to content

Conversation

@lukas-lansky
Copy link
Contributor

@lukas-lansky lukas-lansky commented Apr 19, 2021

As discussed in #50940

Also, backports test fix from #48261

@ghost
Copy link

ghost commented Apr 19, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

As discussed in #50940

Author: lukas-lansky
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

wfurt and others added 2 commits April 19, 2021 13:09
dotnet#48261)

* skip SslStream_ClientCertificate_SendsChain test if chain is not valid

* make test conditional
@lukas-lansky lukas-lansky requested a review from mmitche April 19, 2021 12:13
@akoeplinger
Copy link
Member

Looks good but I think we should disable all of iOS/tvOS/Android builds in 5.0 since we ended up not shipping them there.

@mmitche
Copy link
Member

mmitche commented Apr 20, 2021

@akoeplinger can you handle that on this PR to unblock 5.0?

@lukas-lansky
Copy link
Contributor Author

@akoeplinger @mmitche I don't have merge rights here, so please feel free to finish the PR at your convenience.

@mmitche mmitche merged commit 25d20e9 into dotnet:release/5.0 Apr 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants