Updating the ARM HWIntrinsic test generation script to automatically split the tests #37859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
Member
Author
|
CC. @jkotas, @BruceForstall, @CarolEidt, @echesakovMSFT |
Closed
echesakov
approved these changes
Jun 15, 2020
Contributor
echesakov
left a comment
echesakov
left a comment
There was a problem hiding this comment.
@tannergooding Thanks for fixing the issue! Originally, I though about splitting the tests by the method name - that way it will be easier to debug and reproduce the failures.
However, given the urgency for the fix - let's merge your PR first and I will follow up later.
Member
Author
|
Going to merge to unblock CI. I'll follow up with any remaining feedback that comes after merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
GenerateTests.csxfile to automatically split ISAs into groups of no more thanxtests.xis currently256as that is approx the number of tests inx86.Avx2which has never had issues and should be small enough to not hit any timeout issues.This resolves #37282