Add fast path to SpanHelpers.SequenceEqual using Unsafe.AreSame#123674
Closed
Add fast path to SpanHelpers.SequenceEqual using Unsafe.AreSame#123674
Conversation
Member
|
(Mostly just testing the cooperation of copilot and EgorBot) |
Co-authored-by: EgorBo <[email protected]>
Copilot
AI
changed the title
[WIP] Add fast path for memory location check in SequenceEqual
Add fast path to SpanHelpers.SequenceEqual using Unsafe.AreSame
Jan 27, 2026
This was referenced Jan 27, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds early exit to
SpanHelpers.SequenceEqual(ref byte first, ref byte second, nuint length)whenfirstandsecondreference the same memory location.Previously, the
Unsafe.AreSamecheck was only performed for lengths ≥sizeof(nuint). Now it's checked unconditionally at method entry, consistent withSpanHelpers.T.csandSpanHelpers.Char.cs.Changes
Unsafe.AreSamecheck at method start to returntrueimmediately for same-reference comparisonsLonger:block (now unreachable for same-reference case)byteandcharspans covering same-reference, same-content, and different-content scenariosBenchmark for validation
Post this comment on the PR to trigger EgorBot:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.