Remove some Apple handling from OpenSSL native shim#123581
Merged
vcsjones merged 4 commits intodotnet:mainfrom Jan 28, 2026
Merged
Remove some Apple handling from OpenSSL native shim#123581vcsjones merged 4 commits intodotnet:mainfrom
vcsjones merged 4 commits intodotnet:mainfrom
Conversation
…uilds System.Security.Cryptography.Native.OpenSsl
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Apple-specific conditional compilation code from opensslshim.c since macOS no longer builds the OpenSSL-based System.Security.Cryptography.Native library. Instead, macOS uses System.Security.Cryptography.Native.Apple (as confirmed by the CMake configuration in src/native/libs/CMakeLists.txt).
Changes:
- Removed
__APPLE__preprocessor conditionals and Apple-specific library naming (DYLIBNAME_PREFIX/DYLIBNAME_SUFFIX) - Simplified code to only handle Linux-style library naming (libssl.so.*)
jkotas
approved these changes
Jan 24, 2026
This was referenced Jan 25, 2026
Open
bartonjs
approved these changes
Jan 25, 2026
3 tasks
3 tasks
Member
|
/ba-g infrastructure timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some Apple handling from opensslshim.c since macOS no longer builds System.Security.Cryptography.Native.OpenSsl.