[release/8.0-staging] Add flags when the clang's major version is > 20.0 #121150
+19
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @hoyosjs |
4 tasks
AaronRobinsonMSFT
added
the
Servicing-consider
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates compiler flag configuration for Unix-based builds to use -fno-strict-overflow instead of -fwrapv when using Clang 20.0 or later, and adds -fno-strict-aliasing for Clang 20+.
Key Changes
- Adds version-based conditional logic to use different overflow handling flags based on Clang version
- Introduces
-fno-strict-overflowflag for Clang 20+ (which implies-fwrapvand-fwrapv-pointer) - Adds
-fno-strict-aliasingflag for Clang 20+ to match MSVC behavior
jkoritzinsky
approved these changes
Oct 29, 2025
jkotas
changed the title
This was referenced Oct 29, 2025
Open
tmds
approved these changes
Oct 30, 2025
agocke
added
Servicing-approved
This was referenced Nov 13, 2025
Member
Author
|
/ba-g Unrelated timeouts |
AaronRobinsonMSFT
added a commit
that referenced
this pull request
Nov 14, 2025
…0.0 (#121151) ## Customer Impact - [x] Customer reported - [ ] Found internally These issues were reported in #119706 as problems with clang-21 on Fedora 43. The investigation uncovered that clang introduced a potentially breaking change in clang-20 that we do not currently consume. These build changes impact VMR related builds when linux distrobutions performing source build adopt clang-21. clang-20 breaking change log - https://releases.llvm.org/20.1.0/tools/clang/docs/ReleaseNotes.html#potentially-breaking-changes. This PR contains the minimal changes needed to fix issues from the following PR #120775. .NET 10: #121124 .NET 8: #121150 ## Regression - [ ] Yes - [x] No Build with the new clang-21 compiler will cause the runtime to crash. ## Testing This has been validated using various legs and examples to demonstrate the usage of undefined behavior these flags convert into "defined" behavior in C/C++. ## Risk Low. This has zero impact on our production build since we specifically target clang-18. This is only valid for those partners that are using clang-20+.
AaronRobinsonMSFT
merged commit b95a379
into
dotnet:release/8.0-staging
174 of 179 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
These issues were reported in #119706 as problems with clang-21 on Fedora 43. The investigation uncovered that clang introduced a potentially breaking change in clang-20 that we do not currently consume. These build changes impact VMR related builds when linux distrobutions performing source build adopt clang-21.
clang-20 breaking change log - https://releases.llvm.org/20.1.0/tools/clang/docs/ReleaseNotes.html#potentially-breaking-changes.
This PR contains the minimal changes needed to fix issues from the following PR #120775.
.NET 10: #121124
.NET 9: #121151
Regression
Build with the new clang-21 compiler will cause the runtime to crash.
Testing
This has been validated using various legs and examples to demonstrate the usage of undefined behavior these flags convert into "defined" behavior in C/C++.
Risk
Low. This has zero impact on our production build since we specifically target clang-16. This is only valid for those partners that are using clang-20+.