Fix more diagnostics with CA2263 #100490
Merged
Fix more diagnostics with CA2263 #100490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-meta |
jkotas
reviewed
Apr 1, 2024
Member
jkotas
left a comment
jkotas
left a comment
There was a problem hiding this comment.
There is a lot of interop cleanup and simplification that can be done in the legacy components. I have commented on some of it (it may require annotating method as unsafe).
...pendencyInjection.Abstractions/src/Extensions/ServiceCollectionDescriptorExtensions.Keyed.cs
Outdated
Show resolved
Hide resolved
...ibraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/ComInterop/ComRuntimeHelpers.cs
Outdated
Show resolved
Hide resolved
...ibraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/ComInterop/ComRuntimeHelpers.cs
Outdated
Show resolved
Hide resolved
...braries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/ComInterop/IDispatchComObject.cs
Outdated
Show resolved
Hide resolved
...ctoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/SidList.cs
Outdated
Show resolved
Hide resolved
...rectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AuthZSet.cs
Outdated
Show resolved
Hide resolved
...rectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AuthZSet.cs
Outdated
Show resolved
Hide resolved
....DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Utils.cs
Outdated
Show resolved
Hide resolved
....DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Utils.cs
Outdated
Show resolved
Hide resolved
....DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Utils.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 1, 2024
This was referenced Apr 2, 2024
Closed
Closed
jakobbotsch
pushed a commit
to jakobbotsch/runtime
that referenced
this pull request
Apr 3, 2024
* Fix more diagnostics with CA2263 * Apply feedbacks
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Fix more diagnostics with CA2263 * Apply feedbacks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix more diagnostics found with
CA2263: Prefer generic overload when type is knownExcluded fixing diagnostics for
netstandardMicrosoft.Extensions.DependencyInjection.Specification.TestsLinq.ExpressionsRelated to #99343 (comment)