Initial pass at enabling prebuilt detection #67645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add exclusions for some SBRPs that will be required - Update sbrp and source-build-externals - CPD the sourcelink and xliff tasks dependencies to avoid getting out of sync with arcade - Upgrade a few dependencies from 5.0.0 to 6.0.0/7.0.0 where I felt it may be safe. Still needs some attention around: - Microsoft.Net.Compilers.Toolset - This may simply need to be excluded. I don't think we can add a dependency for this and pull in the stable source-build intermediate package. - Microsoft.DiaSymReader - Maybe an SBRP? Not sure here. It's stable though.
ghost
added
Area-Infrastructure
untriaged
mmitche
commented
Apr 5, 2023
mmitche
commented
Apr 5, 2023
mmitche
commented
Apr 5, 2023
eng/Versions.props
Outdated
| <MicrosoftVisualStudioWorkspaceVSIntegrationVersion>17.1.11-preview-0002</MicrosoftVisualStudioWorkspaceVSIntegrationVersion> | ||
| <MicrosoftWin32PrimitivesVersion>4.3.0</MicrosoftWin32PrimitivesVersion> | ||
| <MicrosoftWin32RegistryVersion>5.0.0</MicrosoftWin32RegistryVersion> | ||
| <MicrosoftWin32RegistryVersion>6.0.0</MicrosoftWin32RegistryVersion> |
Member
Author
There was a problem hiding this comment.
@jaredpar What do you think here? safe to upgrade?
mmitche
commented
Apr 5, 2023
Member
Author
|
@dotnet/source-build-internal |
27 tasks
Member
Author
|
@dotnet/roslyn-infrastructure can someone take a look here? |
jaredpar
reviewed
Apr 19, 2023
jaredpar
reviewed
Apr 19, 2023
jaredpar
reviewed
Apr 19, 2023
…enable-prebuilt-detection
Member
Author
|
@jaredpar A few tweaks to make the PR a little more scoped and remove changes to RunTests. |
jaredpar
approved these changes
Apr 20, 2023
Member
Author
|
Thanks for the feedback. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs some attention around: