Skip to content

Remove target that warns that user needs to upgrade to a newer SDK NetAnalyzers version #7040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 1 commit into from
Nov 22, 2023
Merged

Remove target that warns that user needs to upgrade to a newer SDK NetAnalyzers version #7040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/Tools/GenerateDocumentationAndConfigFiles/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1702,16 +1702,6 @@ static string GetPackageSpecificContents(string packageName)
<EmbeddedFiles Condition="'$(DebugType)' != 'none'" Include="$(PerformanceSensitiveAttributePath)" />
</ItemGroup>
""",
NetAnalyzersPackageName => $"""

<!-- Target to report a warning when SDK NetAnalyzers version is higher than the referenced NuGet NetAnalyzers version -->
<Target Name="_ReportUpgradeNetAnalyzersNuGetWarning" BeforeTargets="CoreCompile" Condition="'$(_SkipUpgradeNetAnalyzersNuGetWarning)' != 'true' ">
<Warning Text ="The .NET SDK has newer analyzers with version '$({NetAnalyzersSDKAssemblyVersionPropertyName})' than what version '$({NetAnalyzersNugetAssemblyVersionPropertyName})' of '{NetAnalyzersPackageName}' package provides. Update or remove this package reference. You can suppress this warning by setting the MSBuild property '_SkipUpgradeNetAnalyzersNuGetWarning' to 'true'."
Condition="'$({NetAnalyzersNugetAssemblyVersionPropertyName})' != '' AND
'$({NetAnalyzersSDKAssemblyVersionPropertyName})' != '' AND
$({NetAnalyzersNugetAssemblyVersionPropertyName}) &lt; $({NetAnalyzersSDKAssemblyVersionPropertyName})"/>
</Target>
""",
ResxSourceGeneratorPackageName => $"""

<!-- Special handling for embedded resources to show as nested in Solution Explorer -->
Expand Down