Remove target that warns that user needs to upgrade to a newer SDK NetAnalyzers version

[carlossanlop]

Addresses part of the problem reported in #6878 by deleting the target that we have determined does not add enough value.

[carlossanlop]

@mavasani Two questions:

• Can you tell me how to test that this works?
• Should I backport this to 8.0?

[codecov]

Codecov Report

Merging #7040 (bb4b456) into main (e600e79) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7040      +/-   ##
==========================================
- Coverage   96.43%   96.43%   -0.01%     
==========================================
  Files        1412     1412              
  Lines      336528   336528              
  Branches    11119    11119              
==========================================
- Hits       324528   324519       -9     
- Misses       9198     9206       +8     
- Partials     2802     2803       +1     

[mavasani]

@carlossanlop There isn’t a non-trivial way to test this as local build will generate a 9.0 versioned preview NuGet package, which will report a warning on a higher versioned analyzer assembly/SDK, which isn’t available yet. I think it’s fine to just delete this target without any manual testing.

Regarding whether we should backport this to 8.0 branch - backporting will help when we release a new .NET SDK which has a higher versioned NetAnalyzers assembly whose corresponding NuGet package isn’t published simultaneously on NuGet.org. I wouldn’t say it is critical, especially if we remember publishing the NuGet package along with the SDK release, but I won’t push back if you feel more comfortable backporting

[mavasani]

@carlossanlop Is this good to be merged?

[carlossanlop]

/backport to release/8.0.2xx

[github-actions]

Started backporting to release/8.0.2xx: https://github.com/dotnet/roslyn-analyzers/actions/runs/6960400450

[github-actions]

@carlossanlop backporting to release/8.0.2xx failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Remove flagging target
Using index info to reconstruct a base tree...
M	src/Tools/GenerateDocumentationAndConfigFiles/Program.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Tools/GenerateDocumentationAndConfigFiles/Program.cs
CONFLICT (content): Merge conflict in src/Tools/GenerateDocumentationAndConfigFiles/Program.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove flagging target
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[github-actions]

@carlossanlop an error occurred while backporting to release/8.0.2xx, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

[carlossanlop]

Oops, just realized the backport failed. I'll need to create the PR manually.