Repository navigation
ci(consul): validate modern key compatibility - #11399
Merged
Merged
Conversation
This was referenced Oct 3, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The image references are synchronized and the documented validation behavior matches Consul 1.21.5 and 1.22.7.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Consul CI coverage and guidance for modern KV key validation.
Changes:
- Upgrades Consul test images from 1.19 to 1.22.7 with synchronized immutable digests.
- Retains the GCR mirror and Docker Hub fallback.
- Documents Consul version compatibility and upgrade configuration.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Updates pinned CI images and fallback. |
test/Extensions/Orleans.Clustering.Consul.Tests/ConsulTestUtils.cs |
Updates the default test container image. |
docs/site/src/content/docs/host/configuration-guide/clustering/consul.md |
Adds version and upgrade guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#9701 restored Consul CI by pinning version 1.19 after Consul 1.21.5 introduced an overly restrictive KV key allowlist. Orleans membership keys contain
:and@, so the pin stopped CI from validating compatibility with current Consul key validation.The later failures addressed by #11366 were separate registry availability failures. Its digest-pinned GCR mirror and Docker Hub fallback remain the correct image acquisition strategy.
Solution
Consul 1.22 removed the restrictive character allowlist while retaining path traversal and leading/trailing-space validation, so Orleans keeps its existing persisted membership key format without a migration.
Closes #9700
Microsoft Reviewers: Open in CodeFlow