Skip to content

ci(consul): validate modern key compatibility - #11399

Merged
ReubenBond merged 1 commit into
dotnet:mainfrom
ReubenBond:rb-fix-consul-ci-tests
Oct 3, 2026
Merged

ReubenBond merged 1 commit into
dotnet:mainfrom
ReubenBond:rb-fix-consul-ci-tests

Conversation

@ReubenBond

@ReubenBond ReubenBond commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Problem

#9701 restored Consul CI by pinning version 1.19 after Consul 1.21.5 introduced an overly restrictive KV key allowlist. Orleans membership keys contain : and @, so the pin stopped CI from validating compatibility with current Consul key validation.

The later failures addressed by #11366 were separate registry availability failures. Its digest-pinned GCR mirror and Docker Hub fallback remain the correct image acquisition strategy.

Solution

  • Upgrade the synchronized Consul test image references from 1.19 to 1.22.7.
  • Preserve ci: pin Consul GCR mirror with Docker Hub fallback #11366's GCR mirror, Docker Hub fallback, and immutable manifest digest.
  • Document that Consul 1.22 or later accepts Orleans silo-address keys and describe the temporary Consul 1.21.5 configuration for upgrades.

Consul 1.22 removed the restrictive character allowlist while retaining path traversal and leading/trailing-space validation, so Orleans keeps its existing persisted membership key format without a migration.

Closes #9700

Microsoft Reviewers: Open in CodeFlow

Copilot AI balanced review requested due to automatic review settings October 3, 2026 08:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The image references are synchronized and the documented validation behavior matches Consul 1.21.5 and 1.22.7.

Review effort: Balanced
Findings: None

What changed in this PR

Updates Consul CI coverage and guidance for modern KV key validation.

Changes:

  • Upgrades Consul test images from 1.19 to 1.22.7 with synchronized immutable digests.
  • Retains the GCR mirror and Docker Hub fallback.
  • Documents Consul version compatibility and upgrade configuration.
File Description
.github/​workflows/​ci.yml Updates pinned CI images and fallback.
test/​Extensions/​Orleans.Clustering.Consul.Tests/​ConsulTestUtils.cs Updates the default test container image.
docs/​site/​src/​content/​docs/​host/​configuration-guide/​clustering/​consul.md Adds version and upgrade guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ReubenBond
ReubenBond merged commit 6a434ec into dotnet:main Oct 3, 2026
84 of 85 checks passed
@ReubenBond
ReubenBond deleted the rb-fix-consul-ci-tests branch October 3, 2026 14:23
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consul CI tests are broken

2 participants