Repository navigation
ci: pin Consul GCR mirror with Docker Hub fallback - #11366
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused changes correctly implement pinned Consul image selection and fallback behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Pins Consul CI images by digest and adds a Docker Hub fallback for registry reliability.
Changes:
- Prefer the pinned GCR mirror, falling back to the identical Docker Hub manifest.
- Pass the successfully pulled image to Testcontainers.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Defines pinned images and fallback selection. |
test/Extensions/Orleans.Clustering.Consul.Tests/ConsulTestUtils.cs |
Configures Testcontainers from the selected image. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Code coverage
Report-only conclusion: current-main baseline stale. The newest successful coverage run tested 6bf11ad, not current main 5993708. Coverage combines every CI test matrix job, including providers, CodeGen, .NET 8/10, Linux, Windows, and macOS, using canonical physical source and branch identities. The comparison remains report-only while normal line and branch variance is calibrated. Coverage details |
Consul provider CI currently pulls an unpinned image from ECR, which can fail intermittently. Prefer the pinned
mirror.gcr.io/hashicorp/consul:1.19image and fall back to the same pinned Docker Hub manifest when Google's best-effort cache is unavailable. The selected image is passed to Testcontainers; the job fails if neither registry can serve it.This is a standalone Consul-only change from
main. It overlaps the Consul portion of #11356, so that portion should be coordinated if either PR lands first.Microsoft Reviewers: Open in CodeFlow