Skip to content

Batch large directory transfer payloads - #10053

Merged
ReubenBond merged 1 commit into
dotnet:mainfrom
ReubenBond:fix/directory-transfer-payload-batching
May 8, 2026
Merged

ReubenBond merged 1 commit into
dotnet:mainfrom
ReubenBond:fix/directory-transfer-payload-batching

Conversation

@ReubenBond

@ReubenBond ReubenBond commented Apr 29, 2026 •

Copy link
Copy Markdown
Member

Summary

Batches large distributed-directory transfer payloads so snapshot and recovery activation fetches stay below the configured message size limit during large range transfers.

Changes

  • Split snapshot transfer reads by subrange.
  • Split recovery activation fetches by subrange.
  • Add batching coverage for large directory partition transfers.

Stack notes

This branch is stacked above #10050. The focused review range is:

feature/distributed-remote-grain-directory..fix/directory-transfer-payload-batching

#10049 stacks above this branch for the directory migration join regression.

Validation

Focused validation run locally:

  • dotnet test test\Orleans.GrainDirectory.Tests\Orleans.GrainDirectory.Tests.csproj --framework net10.0 --filter "FullyQualifiedName~GrainDirectoryRollingUpgradeTests|FullyQualifiedName~GrainDirectoryPartitionBatchingTests|FullyQualifiedName~GrainDirectoryResilienceTests.JoiningSilo_DoesNotLeaveStaleEntriesOnPreviousOwner" -- -parallel none -noshadow

@ReubenBond
ReubenBond force-pushed the fix/directory-transfer-payload-batching branch 3 times, most recently from 8226bb5 to 1d60be0 Compare April 29, 2026 18:23
@ReubenBond
ReubenBond changed the base branch from fix/local-distributed-directory-upgrade to main April 29, 2026 18:23
@ReubenBond ReubenBond closed this Apr 29, 2026
@ReubenBond ReubenBond reopened this Apr 29, 2026
@ReubenBond
ReubenBond force-pushed the fix/directory-transfer-payload-batching branch 3 times, most recently from b19b2f1 to 0c50f65 Compare April 29, 2026 21:01
@ReubenBond

Copy link
Copy Markdown
Member Author

Rebuilt on top of the new #10047 base. This PR is now the batching layer after the coupled transfer/ownership/compatibility fixes.

Split distributed-directory snapshot and recovery activation fetches by subrange so individual messages stay below MaxMessageBodySize during large range transfers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ReubenBond
ReubenBond force-pushed the fix/directory-transfer-payload-batching branch from 890d98e to d8807d8 Compare May 8, 2026 18:58
@ReubenBond
ReubenBond enabled auto-merge May 8, 2026 19:13
@ReubenBond
ReubenBond added this pull request to the merge queue May 8, 2026
Merged via the queue into dotnet:main with commit 61a0016 May 8, 2026
62 checks passed
@ReubenBond
ReubenBond deleted the fix/directory-transfer-payload-batching branch May 8, 2026 19:55
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants