Repository navigation
Stabilize directory ownership checks - #10048
Closed
ReubenBond wants to merge 3 commits into
Closed
ReubenBond wants to merge 3 commits into
ReubenBond wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves correctness of distributed grain directory operations during membership/ownership transitions by waiting for a stable directory-ownership view before serving register/lookup/deregister, and by stamping successful registrations with the membership version used for ownership validation.
Changes:
- Replace per-request
WaitForRange(...); IsOwner(CurrentView, ...)checks with a new helper that waits for a stable ownership view (WaitForOwnershipViewAsync). - Use the captured stable view for ownership assertions and refresh-required responses.
- Stamp new/overridden registrations with the captured view’s membership version instead of the potentially-updated
CurrentView.Version.
Show a summary per file
| File | Description |
|---|---|
| src/Orleans.Runtime/GrainDirectory/GrainDirectoryPartition.Interface.cs | Ensures register/lookup/deregister wait for a stable ownership view and stamps registrations with the validated membership version. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
ReubenBond
force-pushed
the
fix/directory-stable-ownership-view
branch
from
April 28, 2026 22:54
1dc35ac to
4f710e1
Compare
ReubenBond
force-pushed
the
fix/directory-snapshot-transfer-ranges
branch
from
April 28, 2026 22:55
b9007e0 to
46e81cf
Compare
ReubenBond
force-pushed
the
fix/directory-stable-ownership-view
branch
from
April 28, 2026 23:13
4f710e1 to
2d210eb
Compare
ReubenBond
force-pushed
the
fix/directory-snapshot-transfer-ranges
branch
from
April 28, 2026 23:13
46e81cf to
f38fbdd
Compare
ReubenBond
force-pushed
the
fix/directory-stable-ownership-view
branch
from
April 29, 2026 14:51
2d210eb to
84d2be4
Compare
ReubenBond
force-pushed
the
fix/directory-snapshot-transfer-ranges
branch
from
April 29, 2026 14:51
f38fbdd to
4ff2582
Compare
ReubenBond
force-pushed
the
fix/directory-stable-ownership-view
branch
from
April 29, 2026 15:09
84d2be4 to
7f1c458
Compare
ReubenBond
force-pushed
the
fix/directory-snapshot-transfer-ranges
branch
from
April 29, 2026 15:10
4ff2582 to
4993770
Compare
ReubenBond
force-pushed
the
fix/directory-stable-ownership-view
branch
from
April 29, 2026 18:23
7f1c458 to
223d182
Compare
This was referenced Apr 29, 2026
ReubenBond
force-pushed
the
fix/directory-snapshot-transfer-ranges
branch
from
April 29, 2026 18:26
4993770 to
8f24b05
Compare
ReubenBond
changed the base branch from
fix/directory-snapshot-transfer-ranges
to
main
April 29, 2026 18:29
ReubenBond
force-pushed
the
fix/directory-stable-ownership-view
branch
from
April 29, 2026 19:40
223d182 to
b44650b
Compare
Query each previous owner only for the intersection of its prior range and the range being acquired during distributed directory migration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Split distributed-directory snapshot and recovery activation fetches by subrange so individual messages stay below MaxMessageBodySize during large range transfers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Wait on a stable ownership view before serving register, lookup, and deregister requests, and stamp registrations with the captured membership version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReubenBond
force-pushed
the
fix/directory-stable-ownership-view
branch
from
April 29, 2026 19:46
b44650b to
9078abd
Compare
Member
Author
|
Closing this as folded into #10047. The stable ownership check commit from this PR is now part of the first merge candidate so that every PR can target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 2/3, based on: #10047
This waits for a stable directory ownership view before serving register, lookup, and deregister operations, then stamps registrations with the captured membership version used for ownership validation.
Microsoft Reviewers: Open in CodeFlow