Skip to content

Configure Android SoftInput for Issue28986 SafeArea tests#33144

Closed
Copilot wants to merge 7 commits intomainfrom
copilot/update-issue28986-tests
Closed

Configure Android SoftInput for Issue28986 SafeArea tests#33144
Copilot wants to merge 7 commits intomainfrom
copilot/update-issue28986-tests

Conversation

Copy link
Contributor

Copilot AI commented Dec 12, 2025 •
edited
Loading

Description of Change

Configures Android SoftInput.AdjustNothing mode for all Issue28986 SafeArea test files to ensure consistent keyboard inset behavior across platforms.

Changes:

  • Added Android.Views using directive (platform-gated) to each Issue28986 test file
  • Configured SoftInput.AdjustNothing | SoftInput.StateUnspecified in test constructors
  • This gives tests full control over keyboard insets on Android, providing iOS-like behavior for consistent SafeArea testing

Files Updated:

  • Issue28986.xaml.cs
  • Issue28986_Border.xaml.cs
  • Issue28986_ContentPage.xaml.cs
  • Issue28986_ContentView.xaml.cs
  • Issue28986_FlyoutPage.cs
  • Issue28986_NavigationPage.cs
  • Issue28986_SafeAreaBorderOrientation.xaml.cs
  • Issue28986_ScrollView.xaml.cs
  • Issue28986_Shell.cs

Issues Fixed

Improves SafeArea test infrastructure for #28986

Original prompt

Can you create a PR based on #32405 that only has the changes to the Issue28986 tests and that's it?

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update tests for Issue 28986 Extract Issue28986 test changes from PR #32405 Dec 12, 2025
Copilot AI requested a review from PureWeen December 12, 2025 22:11
PureWeen
PureWeen reviewed Dec 12, 2025
View reviewed changes
.gitignore
Copy link
Member

@PureWeen PureWeen Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot revert this change

Copy link
Contributor Author

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Reverted in commit 59657fd.

Copilot AI requested a review from PureWeen December 12, 2025 22:31
PureWeen
PureWeen reviewed Dec 13, 2025
View reviewed changes
src/Core/src/Handlers/HybridWebView/HybridWebView.js.map Outdated
Copy link
Member

@PureWeen PureWeen Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot revert these changes

Copy link
Contributor Author

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Removed in commit cfbc20a.

Copilot AI requested a review from PureWeen December 13, 2025 00:33
This was referenced Dec 13, 2025
Open
Open
Open
@sheiksyedm
Copy link
Contributor

sheiksyedm commented Dec 15, 2025

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 15, 2025

No pipelines are associated with this pull request.

@PureWeen
Copy link
Member

PureWeen commented Dec 17, 2025

@copilot update the title and description of this pr to accurately describe what its doing

It's not important that it copied from a different pr

This is now a separate pr with its own purpose

Copy link
Contributor Author

Copilot AI commented Dec 17, 2025

@copilot update the title and description of this pr to accurately describe what its doing

It's not important that it copied from a different pr...

Updated the PR title and description to focus on the purpose of the changes rather than the origin.

New Title: Configure Android SoftInput for Issue28986 SafeArea tests

New Description:

Description of Change

Configures Android SoftInput.AdjustNothing mode for all Issue28986 SafeArea test files to ensure consistent keyboard inset behavior across platforms.

Changes:

  • Added Android.Views using directive (platform-gated) to each Issue28986 test file
  • Configured SoftInput.AdjustNothing | SoftInput.StateUnspecified in test constructors
  • This gives tests full control over keyboard insets on Android, providing iOS-like behavior for consistent SafeArea testing

Files Updated:

  • Issue28986.xaml.cs
  • Issue28986_Border.xaml.cs
  • Issue28986_ContentPage.xaml.cs
  • Issue28986_ContentView.xaml.cs
  • Issue28986_FlyoutPage.cs
  • Issue28986_NavigationPage.cs
  • Issue28986_SafeAreaBorderOrientation.xaml.cs
  • Issue28986_ScrollView.xaml.cs
  • Issue28986_Shell.cs

Issues Fixed

Improves SafeArea test infrastructure for #28986

Copilot AI changed the title Extract Issue28986 test changes from PR #32405 Configure Android SoftInput for Issue28986 SafeArea tests Dec 17, 2025
@NirmalKumarYuvaraj
Copy link
Contributor

NirmalKumarYuvaraj commented Dec 29, 2025

@copilot , remove the Hybridwebview.js map file.

@NirmalKumarYuvaraj NirmalKumarYuvaraj mentioned this pull request Dec 29, 2025
Open
Copy link
Contributor Author

Copilot AI commented Dec 29, 2025

@copilot , remove the Hybridwebview.js map file.

Done. Removed in commit a8fee46.

This was referenced Dec 29, 2025
Open
Open
@PureWeen PureWeen closed this Dec 29, 2025
@PureWeen PureWeen deleted the copilot/update-issue28986-tests branch December 29, 2025 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PureWeen PureWeen Awaiting requested review from PureWeen

@NirmalKumarYuvaraj NirmalKumarYuvaraj Awaiting requested review from NirmalKumarYuvaraj

Assignees

@PureWeen PureWeen

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sheiksyedm @PureWeen @NirmalKumarYuvaraj