Skip to content

[CoreMidi] Obsolete the MidiPacket.Bytes property. #19705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 2 commits into from
Jan 2, 2024
Merged

[CoreMidi] Obsolete the MidiPacket.Bytes property. #19705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83eeafa
[CoreMidi] Obsolete the MidiPacket.Bytes property.
rolfbjarne Dec 22, 2023
bd5773b
Fix build
rolfbjarne Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/CoreMidi/MidiServices.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#nullable enable

using System;
using System.ComponentModel;
using System.Diagnostics;
using System.Runtime.InteropServices;
using ObjCRuntime;
Expand Down Expand Up @@ -835,6 +836,9 @@ internal IntPtr BytePointer {
get { return byteptr; }
}

#if !XAMCORE_5_0
[EditorBrowsable (EditorBrowsableState.Never)]
[Obsolete ("This property may return a pointer to a managed object, and this pointer is never safe to use. Use ByteArray or BytePointer instead.")]
public IntPtr Bytes {
get {
if (bytes is null || bytes.Length < 1)
Expand All @@ -846,6 +850,7 @@ public IntPtr Bytes {
}
}
}
#endif

internal static int GetPacketLength (int payload_length)
{
Expand Down