[CoreMidi] Obsolete the MidiPacket.Bytes property. #19705
Conversation
It's inherently unsafe, because it may return a pointer to inside a managed array - which points to random memory if the GC collects or moves the array. So obsolete the property, and remove it for XAMCORE_5_0.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 235 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
PR #19705 obsoleted `MidiPacket.Bytes` with obsoletion message that suggests to use internal properties. This PR changes those properties to be public so that it's actually usable. --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
3 participants
It's inherently unsafe, because it may return a pointer to inside a managed
array - which points to random memory if the GC collects or moves the array.
So obsolete the property, and remove it for XAMCORE_5_0.