Skip to content

[CoreGraphics] Add support for xcode 15 beta 6. #18838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mandel-macaque merged 4 commits into from
Aug 30, 2023
Merged

[CoreGraphics] Add support for xcode 15 beta 6. #18838

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81c88b6
[CoreGraphics] Add support for xcode 15 beta 6.
mandel-macaque Aug 26, 2023
b56756b
Auto-format source code
Aug 26, 2023
5627d69
Apply suggestions from code review
mandel-macaque Aug 28, 2023
7c6d187
Update src/CoreGraphics/CGContext.cs
mandel-macaque Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/CoreGraphics/CGContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,6 +1420,21 @@ public CGBitmapContext AsBitmapContext ()
{
return new CGBitmapContext (Handle, false);
}

#if NET
[SupportedOSPlatform ("ios17.0")]
[SupportedOSPlatform ("maccatalyst17.0")]
[SupportedOSPlatform ("macos14.0")]
[SupportedOSPlatform ("tvos17.0")]
Comment on lines +1425 to +1428
Copy link
Copy Markdown
Contributor

@haritha-mohan haritha-mohan Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the diff in how we define the platform attrs for .net vs legacy? iirc these bindings that are within a framework directory go through one less pass through the generator, so assuming that has something to do with it?

Copy link
Copy Markdown
Contributor Author

@mandel-macaque mandel-macaque Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is manually generated code, both need to be added. in the generator written code this is added. Look at the .g.cs files.

#else
[Mac (14, 0), iOS (17, 0), TV (17, 0), MacCatalyst (17, 0), Watch (10, 0)]
#endif
[DllImport (Constants.CoreGraphicsLibrary)]
static extern void CGContextDrawConicGradient (/* CGContext */ IntPtr context, /*[NullAllowed] CGGradient*/ IntPtr gradient, CGPoint center, nfloat angle);

public void DrawConicGradient (CGGradient gradient, CGPoint point, nfloat angle) =>
Comment thread
mandel-macaque marked this conversation as resolved.
Outdated
CGContextDrawConicGradient (Handle, gradient.GetHandle (), point, angle);

#endif // !COREBUILD
}
}
1 change: 0 additions & 1 deletion tests/xtro-sharpie/api-annotations-dotnet/iOS-CoreGraphics.todo
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/xtro-sharpie/api-annotations-dotnet/macOS-CoreGraphics.todo
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/xtro-sharpie/api-annotations-dotnet/tvOS-CoreGraphics.todo
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/xtro-sharpie/iOS-CoreGraphics.todo
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/xtro-sharpie/macOS-CoreGraphics.todo
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/xtro-sharpie/tvOS-CoreGraphics.todo
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/xtro-sharpie/watchOS-CoreGraphics.todo
View file
Open in desktop

This file was deleted.