[CoreGraphics] Add support for xcode 15 beta 6. by mandel-macaque · Pull Request #18838 · dotnet/macios

mandel-macaque · 2023-08-26T20:58:42Z

No description provided.

github-actions · 2023-08-26T21:03:22Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

dalexsoto

after name fix

rolfbjarne · 2023-08-28T12:53:19Z

+		[DllImport (Constants.CoreGraphicsLibrary)]
+		static extern void CGContextDrawConicGradient (/* CGContext */ IntPtr context, /*[NullAllowed] CGGradient*/ IntPtr gradient, CGPoint center, nfloat angle);
+
+		public void CGContextDrawConicGradient (CGGradient gradient, CGPoint point, nfloat angle) =>


Suggested change

public void CGContextDrawConicGradient (CGGradient gradient, CGPoint point, nfloat angle) =>

public void CGContextDrawConicGradient (CGGradient? gradient, CGPoint point, nfloat angle) =>

tj-devel709

After other comments

Co-authored-by: Alex Soto <alex@alexsoto.me> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

vs-mobiletools-engineering-service2 · 2023-08-28T20:36:33Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-28T21:04:56Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-28T21:08:12Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-28T21:14:51Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 7c6d187c4ed5bb35dc921d581012db5ed2b18119 [PR build]

vs-mobiletools-engineering-service2 · 2023-08-28T21:15:10Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7c6d187c4ed5bb35dc921d581012db5ed2b18119 [PR build]

haritha-mohan · 2023-08-28T22:41:12Z

+		[SupportedOSPlatform ("ios17.0")]
+		[SupportedOSPlatform ("maccatalyst17.0")]
+		[SupportedOSPlatform ("macos14.0")]
+		[SupportedOSPlatform ("tvos17.0")]


why the diff in how we define the platform attrs for .net vs legacy? iirc these bindings that are within a framework directory go through one less pass through the generator, so assuming that has something to do with it?

This is manually generated code, both need to be added. in the generator written code this is added. Look at the .g.cs files.

vs-mobiletools-engineering-service2 · 2023-08-29T22:40:26Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 237 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch: All 38 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download

Pipeline on Agent
Hash: 7c6d187c4ed5bb35dc921d581012db5ed2b18119 [PR build]

mandel-macaque and others added 2 commits August 26, 2023 16:56

[CoreGraphics] Add support for xcode 15 beta 6.

81c88b6

Auto-format source code

b56756b

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Aug 28, 2023

View reviewed changes

Comment thread src/CoreGraphics/CGContext.cs Outdated

rolfbjarne requested changes Aug 28, 2023

View reviewed changes

tj-devel709 approved these changes Aug 28, 2023

View reviewed changes

Apply suggestions from code review

5627d69

Co-authored-by: Alex Soto <alex@alexsoto.me> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

mandel-macaque commented Aug 28, 2023

View reviewed changes

Comment thread src/CoreGraphics/CGContext.cs Outdated

Update src/CoreGraphics/CGContext.cs

7c6d187

haritha-mohan reviewed Aug 28, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Aug 29, 2023

View reviewed changes

mandel-macaque merged commit 9a54c6c into dotnet:net8.0-xcode15 Aug 30, 2023

mandel-macaque deleted the net8.0-xcode15-coregraphics branch August 30, 2023 13:42

	public void CGContextDrawConicGradient (CGGradient gradient, CGPoint point, nfloat angle) =>
	public void CGContextDrawConicGradient (CGGradient? gradient, CGPoint point, nfloat angle) =>

Conversation

mandel-macaque commented Aug 26, 2023

Uh oh!

github-actions Bot commented Aug 26, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rolfbjarne Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

tj-devel709 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

haritha-mohan Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 29, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants