-
Notifications
You must be signed in to change notification settings - Fork 565
[Symbols] Add support for the new Xcode 15 Symbols framework. #18642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
fc487b0
749396f
b7cbc27
3f0eae2
3bb1533
eaf2145
d7b8bcc
f31fd2f
bf860be
956e3fc
a904938
9092680
5b7e4a3
3123711
6b81539
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,215 @@ | ||||||
| using CoreFoundation; | ||||||
| using ObjCRuntime; | ||||||
| using Foundation; | ||||||
|
|
||||||
| using System; | ||||||
|
|
||||||
| namespace Symbols { | ||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSObject))] | ||||||
| interface NSSymbolEffect : NSCopying, NSSecureCoding { } | ||||||
|
|
||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSObject))] | ||||||
| interface NSSymbolContentTransition : NSCopying, NSSecureCoding { } | ||||||
|
mandel-macaque marked this conversation as resolved.
|
||||||
|
|
||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSObject))] | ||||||
| [DisableDefaultCtor] | ||||||
| interface NSSymbolEffectOptions : NSCopying, NSSecureCoding { | ||||||
| [Static] | ||||||
| [Export ("options")] | ||||||
| NSSymbolEffectOptions CreateOptions (); | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it sounds better if you remove
Suggested change
|
||||||
|
|
||||||
| [Static] | ||||||
| [Export ("optionsWithRepeating")] | ||||||
| NSSymbolEffectOptions CreateOptionsWithRepeating (); | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same, but also removing
Suggested change
and the same for the other Get and Create methods here. This matches the Swift names better (and also sounds better). |
||||||
|
|
||||||
| [Export ("optionsWithRepeating")] | ||||||
| NSSymbolEffectOptions GetOptionsWithRepeating (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("optionsWithNonRepeating")] | ||||||
| NSSymbolEffectOptions CreateOptionsWithNonRepeating (); | ||||||
|
|
||||||
| [Export ("optionsWithNonRepeating")] | ||||||
| NSSymbolEffectOptions GetOptionsWithNonRepeating (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("optionsWithRepeatCount:")] | ||||||
| NSSymbolEffectOptions CreateOptionsWithRepeatCount (nint count); | ||||||
|
|
||||||
| [Export ("optionsWithRepeatCount:")] | ||||||
| NSSymbolEffectOptions GetOptionsWithRepeatCount (nint count); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("optionsWithSpeed:")] | ||||||
| NSSymbolEffectOptions CreateOptionsWithSpeed (double speed); | ||||||
|
|
||||||
| [Export ("optionsWithSpeed:")] | ||||||
| NSSymbolEffectOptions GetOptionsWithSpeed (double speed); | ||||||
| } | ||||||
|
|
||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSSymbolEffect))] | ||||||
| interface NSSymbolPulseEffect { | ||||||
|
mandel-macaque marked this conversation as resolved.
|
||||||
| [Static] | ||||||
| [Export ("effect")] | ||||||
| NSSymbolPulseEffect CreateEffect (); | ||||||
|
|
||||||
| [Export ("effectWithByLayer")] | ||||||
| NSSymbolPulseEffect GetEffectWithByLayer (); | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are properties in Swift (https://developer.apple.com/documentation/symbols/pulsesymboleffect/4197828-bylayer)
Suggested change
|
||||||
|
|
||||||
| [Export ("effectWithWholeSymbol")] | ||||||
| NSSymbolPulseEffect GetEffectWithWholeSymbol (); | ||||||
| } | ||||||
|
|
||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSSymbolEffect))] | ||||||
| interface NSSymbolBounceEffect { | ||||||
|
mandel-macaque marked this conversation as resolved.
|
||||||
| [Static] | ||||||
| [Export ("effect")] | ||||||
| NSSymbolBounceEffect CreateEffect (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("bounceUpEffect")] | ||||||
| NSSymbolBounceEffect CreateBounceUpEffect (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("bounceDownEffect")] | ||||||
| NSSymbolBounceEffect CreateBounceDownEffect (); | ||||||
|
|
||||||
| [Export ("effectWithByLayer")] | ||||||
| NSSymbolBounceEffect GetEffectWithByLayer (); | ||||||
|
|
||||||
| [Export ("effectWithWholeSymbol")] | ||||||
| NSSymbolBounceEffect GetEffectWithWholeSymbol (); | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same, these can be properties and named better. |
||||||
| } | ||||||
|
|
||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSSymbolEffect))] | ||||||
| interface NSSymbolVariableColorEffect { | ||||||
|
mandel-macaque marked this conversation as resolved.
|
||||||
| [Static] | ||||||
| [Export ("effect")] | ||||||
| NSSymbolVariableColorEffect CreateEffect (); | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| [Export ("effectWithIterative")] | ||||||
| NSSymbolVariableColorEffect GetEffectWithIterative (); | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same, simplified and property:
Suggested change
|
||||||
|
|
||||||
| [Export ("effectWithCumulative")] | ||||||
| NSSymbolVariableColorEffect GetEffectWithCumulative (); | ||||||
|
|
||||||
| [Export ("effectWithReversing")] | ||||||
| NSSymbolVariableColorEffect GetEffectWithReversing (); | ||||||
|
|
||||||
| [Export ("effectWithNonReversing")] | ||||||
| NSSymbolVariableColorEffect GetEffectWithNonReversing (); | ||||||
|
|
||||||
| [Export ("effectWithHideInactiveLayers")] | ||||||
| NSSymbolVariableColorEffect GetEffectWithHideInactiveLayers (); | ||||||
|
|
||||||
| [Export ("effectWithDimInactiveLayers")] | ||||||
| NSSymbolVariableColorEffect GetEffectWithDimInactiveLayers (); | ||||||
| } | ||||||
|
|
||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSSymbolEffect))] | ||||||
| interface NSSymbolScaleEffect { | ||||||
|
mandel-macaque marked this conversation as resolved.
|
||||||
| [Static] | ||||||
| [Export ("effect")] | ||||||
| NSSymbolScaleEffect CreateEffect (); | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| [Static] | ||||||
| [Export ("scaleUpEffect")] | ||||||
| NSSymbolScaleEffect CreateScaleUpEffect (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("scaleDownEffect")] | ||||||
| NSSymbolScaleEffect CreateScaleDownEffect (); | ||||||
|
|
||||||
| [Export ("effectWithByLayer")] | ||||||
| NSSymbolScaleEffect GetEffectWithByLayer (); | ||||||
|
|
||||||
| [Export ("effectWithWholeSymbol")] | ||||||
| NSSymbolScaleEffect GetEffectWithWholeSymbol (); | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Simplified properties |
||||||
| } | ||||||
|
|
||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSSymbolEffect))] | ||||||
| interface NSSymbolAppearEffect { | ||||||
|
mandel-macaque marked this conversation as resolved.
|
||||||
| [Static] | ||||||
| [Export ("effect")] | ||||||
| NSSymbolAppearEffect CreateEffect (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("appearUpEffect")] | ||||||
| NSSymbolAppearEffect CreateAppearUpEffect (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("appearDownEffect")] | ||||||
| NSSymbolAppearEffect CreateAppearDownEffect (); | ||||||
|
|
||||||
| [Export ("effectWithByLayer")] | ||||||
| NSSymbolAppearEffect GetEffectWithByLayer (); | ||||||
|
|
||||||
| [Export ("effectWithWholeSymbol")] | ||||||
| NSSymbolAppearEffect GetEffectWithWholeSymbol (); | ||||||
| } | ||||||
|
|
||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSSymbolEffect))] | ||||||
| interface NSSymbolDisappearEffect { | ||||||
|
mandel-macaque marked this conversation as resolved.
|
||||||
| [Static] | ||||||
| [Export ("effect")] | ||||||
| NSSymbolDisappearEffect CreateEffect (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("disappearUpEffect")] | ||||||
| NSSymbolDisappearEffect CreateDisappearUpEffect (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("disappearDownEffect")] | ||||||
| NSSymbolDisappearEffect CreateDisappearDownEffect (); | ||||||
|
|
||||||
| [Export ("effectWithByLayer")] | ||||||
| NSSymbolDisappearEffect GetEffectWithByLayer (); | ||||||
|
|
||||||
| [Export ("effectWithWholeSymbol")] | ||||||
| NSSymbolDisappearEffect GetEffectWithWholeSymbol (); | ||||||
| } | ||||||
|
|
||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSSymbolContentTransition))] | ||||||
| interface NSSymbolReplaceContentTransition { | ||||||
|
mandel-macaque marked this conversation as resolved.
|
||||||
| [Static] | ||||||
| [Export ("transition")] | ||||||
| NSSymbolReplaceContentTransition CreateTransition (); | ||||||
|
mandel-macaque marked this conversation as resolved.
Outdated
|
||||||
|
|
||||||
| [Static] | ||||||
| [Export ("replaceDownUpTransition")] | ||||||
| NSSymbolReplaceContentTransition CreateReplaceDownUpTransition (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("replaceUpUpTransition")] | ||||||
| NSSymbolReplaceContentTransition CreateReplaceUpUpTransition (); | ||||||
|
|
||||||
| [Static] | ||||||
| [Export ("replaceOffUpTransition")] | ||||||
| NSSymbolReplaceContentTransition CreateReplaceOffUpTransition (); | ||||||
|
|
||||||
| [Export ("transitionWithByLayer")] | ||||||
| NSSymbolReplaceContentTransition GetTransitionWithByLayer (); | ||||||
|
|
||||||
| [Export ("transitionWithWholeSymbol")] | ||||||
| NSSymbolReplaceContentTransition GetTransitionWithWholeSymbol (); | ||||||
| } | ||||||
|
|
||||||
| [Watch (10, 0), TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||||||
| [BaseType (typeof (NSSymbolContentTransition))] | ||||||
| interface NSSymbolAutomaticContentTransition { | ||||||
|
mandel-macaque marked this conversation as resolved.
|
||||||
| [Static] | ||||||
| [Export ("transition")] | ||||||
| NSSymbolAutomaticContentTransition CreateTransition (); | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I stopped suggesting, they all follow the same pattern :)
mandel-macaque marked this conversation as resolved.
Outdated
|
||||||
| } | ||||||
|
|
||||||
| } | ||||||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.