[Symbols] Add support for the new Xcode 15 Symbols framework. by mandel-macaque · Pull Request #18642 · dotnet/macios

mandel-macaque · 2023-08-05T22:08:59Z

No description provided.

mandel-macaque · 2023-08-05T22:09:21Z

Leaving as draft until we land the xcode15 support. But good to keep the record straight.

github-actions · 2023-08-05T22:13:36Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

rolfbjarne · 2023-08-08T14:49:01Z

+	interface NSSymbolEffectOptions : NSCopying, NSSecureCoding {
+		[Static]
+		[Export ("options")]
+		NSSymbolEffectOptions CreateOptions ();


I think it sounds better if you remove Options:

Suggested change

NSSymbolEffectOptions CreateOptions ();

NSSymbolEffectOptions Create ();

rolfbjarne · 2023-08-08T14:49:32Z

+
+		[Static]
+		[Export ("optionsWithRepeating")]
+		NSSymbolEffectOptions CreateOptionsWithRepeating ();


Same, but also removing With:

Suggested change

NSSymbolEffectOptions CreateOptionsWithRepeating ();

NSSymbolEffectOptions CreateRepeating ();

and the same for the other Get and Create methods here.

This matches the Swift names better (and also sounds better).

rolfbjarne · 2023-08-08T14:50:37Z

+		NSSymbolPulseEffect CreateEffect ();
+
+		[Export ("effectWithByLayer")]
+		NSSymbolPulseEffect GetEffectWithByLayer ();


These are properties in Swift (https://developer.apple.com/documentation/symbols/pulsesymboleffect/4197828-bylayer)

Suggested change

NSSymbolPulseEffect GetEffectWithByLayer ();

NSSymbolPulseEffect ByLayer { get; }

rolfbjarne · 2023-08-08T14:53:41Z

+		[Export ("effectWithByLayer")]
+		NSSymbolBounceEffect GetEffectWithByLayer ();
+
+		[Export ("effectWithWholeSymbol")]
+		NSSymbolBounceEffect GetEffectWithWholeSymbol ();


Same, these can be properties and named better.

rolfbjarne · 2023-08-08T14:53:55Z

+		NSSymbolVariableColorEffect CreateEffect ();
+
+		[Export ("effectWithIterative")]
+		NSSymbolVariableColorEffect GetEffectWithIterative ();


Same, simplified and property:

Suggested change

NSSymbolVariableColorEffect GetEffectWithIterative ();

NSSymbolVariableColorEffect Iterative { get; }

rolfbjarne · 2023-08-08T14:54:31Z

+	interface NSSymbolVariableColorEffect {
+		[Static]
+		[Export ("effect")]
+		NSSymbolVariableColorEffect CreateEffect ();


Suggested change

NSSymbolVariableColorEffect CreateEffect ();

NSSymbolVariableColorEffect Create ();

rolfbjarne · 2023-08-08T14:54:39Z

+	interface NSSymbolScaleEffect {
+		[Static]
+		[Export ("effect")]
+		NSSymbolScaleEffect CreateEffect ();


Suggested change

NSSymbolScaleEffect CreateEffect ();

NSSymbolScaleEffect Create ();

rolfbjarne · 2023-08-08T14:54:57Z

+		[Export ("effectWithByLayer")]
+		NSSymbolScaleEffect GetEffectWithByLayer ();
+
+		[Export ("effectWithWholeSymbol")]
+		NSSymbolScaleEffect GetEffectWithWholeSymbol ();


Simplified properties

rolfbjarne · 2023-08-08T14:55:21Z

+	interface NSSymbolAutomaticContentTransition {
+		[Static]
+		[Export ("transition")]
+		NSSymbolAutomaticContentTransition CreateTransition ();


I stopped suggesting, they all follow the same pattern :)

…marin-macios into net8.0-xcode15-symbols

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

dalexsoto

Nice 👍

Co-authored-by: Alex Soto <alex@alexsoto.me>

vs-mobiletools-engineering-service2 · 2023-08-14T21:50:09Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 6b8153937945672a94e4e6574709f01458ce921f [PR build]

vs-mobiletools-engineering-service2 · 2023-08-14T21:59:19Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-14T22:00:07Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-14T22:01:24Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-14T22:27:46Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
watchOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 6b8153937945672a94e4e6574709f01458ce921f [PR build]

vs-mobiletools-engineering-service2 · 2023-08-15T00:17:28Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 2 tests failed, 235 tests passed.

Failures

❌ framework tests

1 tests failed, 7 tests passed.

Details

framework-test/Mac Modern/Debug: BuildFailure

Html Report (VSDrops) Download

❌ mononative tests

1 tests failed, 5 tests passed.

Details

mono-native-unified/Mac Modern/Debug: TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 38 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 6b8153937945672a94e4e6574709f01458ce921f [PR build]

mandel-macaque · 2023-08-15T15:53:41Z

Failures are un related.

[Symbols] Add support for the new Xcode 15 Symbols framework.

fc487b0

Auto-format source code

749396f

This comment has been minimized.

Sign in to view

Merge branch 'net8.0-xcode15' into net8.0-xcode15-symbols

b7cbc27

mandel-macaque marked this pull request as ready for review August 8, 2023 14:32

mandel-macaque requested a review from rolfbjarne as a code owner August 8, 2023 14:32

rolfbjarne requested changes Aug 8, 2023

View reviewed changes

mandel-macaque added 4 commits August 8, 2023 11:22

Address reviews.

3f0eae2

Merge branch 'net8.0-xcode15-symbols' of github.com:mandel-macaque/xa…

3bb1533

…marin-macios into net8.0-xcode15-symbols

No need to add Effect in the Create method.

eaf2145

Properties over methods.

d7b8bcc

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Aug 9, 2023

View reviewed changes

mandel-macaque commented Aug 9, 2023

View reviewed changes

Comment thread src/symbols.cs Outdated

Apply suggestions from code review

f31fd2f

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

This comment has been minimized.

Sign in to view

Update src/symbols.cs

5b7e4a3

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

rolfbjarne approved these changes Aug 11, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto requested changes Aug 12, 2023

View reviewed changes

Apply suggestions from code review

3123711

Co-authored-by: Alex Soto <alex@alexsoto.me>

This comment has been minimized.

Sign in to view

Update src/symbols.cs

6b81539

Co-authored-by: Alex Soto <alex@alexsoto.me>

dalexsoto approved these changes Aug 14, 2023

View reviewed changes

mandel-macaque merged commit d5d14f6 into dotnet:net8.0-xcode15 Aug 15, 2023

mandel-macaque deleted the net8.0-xcode15-symbols branch August 15, 2023 15:53

	NSSymbolEffectOptions CreateOptions ();
	NSSymbolEffectOptions Create ();

	NSSymbolEffectOptions CreateOptionsWithRepeating ();
	NSSymbolEffectOptions CreateRepeating ();

	NSSymbolPulseEffect GetEffectWithByLayer ();
	NSSymbolPulseEffect ByLayer { get; }

	NSSymbolVariableColorEffect GetEffectWithIterative ();
	NSSymbolVariableColorEffect Iterative { get; }

	NSSymbolVariableColorEffect CreateEffect ();
	NSSymbolVariableColorEffect Create ();

	NSSymbolScaleEffect CreateEffect ();
	NSSymbolScaleEffect Create ();

Conversation

mandel-macaque commented Aug 5, 2023

Uh oh!

mandel-macaque commented Aug 5, 2023

Uh oh!

github-actions Bot commented Aug 5, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 14, 2023

💻 [CI Build] Windows Integration Tests passed 💻