Skip to content

[release/7.0.1xx-xcode14-rc2] [msbuild] Hot Restart fixes #16005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 2 commits into from
Sep 19, 2022
Merged

[release/7.0.1xx-xcode14-rc2] [msbuild] Hot Restart fixes #16005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e8d438
[msbuild] Include MauiAssets into the Hot Restart bundle
emaf Sep 15, 2022
740566c
[msbuild] Avoid copying unnecessary files to the Hot Restart app
emaf Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.HotRestart.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<CollectBundleResources
OptimizePropertyLists="$(OptimizePropertyLists)"
OptimizePNGs="$(OptimizePNGs)"
BundleResources="@(Content);@(BundleResource)"
BundleResources="@(Content);@(BundleResource);@(MauiAsset)"
ProjectDir="$(MSBuildProjectDirectory)"
ResourcePrefix="$(IPhoneResourcePrefix)">

Expand Down Expand Up @@ -163,9 +163,8 @@
<_FilesToHotRestartContent Include="@(_FilesToHotRestartContent -> '%(RootDir)%(Directory)%(Filename).pdb')"
Condition="Exists('%(RootDir)%(Directory)%(Filename).pdb')" />

<!-- TODO: We stopped filtering assemblies until we fix the net6 build -->
<!-- <_FilesToHotRestartContent Include="@(ReferenceCopyLocalPaths -> Distinct())" Condition="Exists('$(HotRestartAppBundlePath)\%(Filename)%(Extension)') == 'false'"/> -->
<_FilesToHotRestartContent Include="@(ReferenceCopyLocalPaths -> Distinct())"/>
<_FilesToHotRestartContent Include="@(ReferenceCopyLocalPaths -> Distinct())"
Condition="Exists('$(HotRestartAppBundlePath)\%(Filename)%(Extension)') == 'false' And '%(Extension)' != '.a' And '%(Extension)' != '.dylib' And '%(Extension)' != '.dat'"/>
</ItemGroup>
</Target>

Expand Down