Skip to content

[release/7.0.1xx-xcode14-rc2] [msbuild] Hot Restart fixes#16005

Merged
rolfbjarne merged 2 commits intodotnet:release/7.0.1xx-xcode14-rc2from
vs-mobiletools-engineering-service2:backport-pr-15979-to-release/7.0.1xx-xcode14-rc2
Sep 19, 2022
Merged

[release/7.0.1xx-xcode14-rc2] [msbuild] Hot Restart fixes#16005
rolfbjarne merged 2 commits intodotnet:release/7.0.1xx-xcode14-rc2from
vs-mobiletools-engineering-service2:backport-pr-15979-to-release/7.0.1xx-xcode14-rc2

Conversation

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Adds missing css files needed on Maui Blazor apps and avoids copying unnecessary files into the bundle (overdue task since the .NET migration).

Backport of #15979

We were missing to copy MauiAssets, like css styles for Maui Blazor apps, into the Hot Restart app bundle.

Fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/1540183
From the comment in this line, this is a long overdue task.

We should avoid copying duplicated or unnecessary files to the Hot Restart Content folder to reduce the bundle size.
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

No test package could be found for tests on macOS M1 - Mac Big Sur (11.5)

Pipeline on Agent
Hash: 740566cf3b7292493ba12787da593ae48cf261ea [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌

No test package could be found for tests on macOS Mac Catalina (10.15)

Pipeline on Agent
Hash: 740566cf3b7292493ba12787da593ae48cf261ea [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

🔥 Failed to compare API and create generator diff 🔥

Failed to update apidiff references

Pipeline on Agent
Hash: 740566cf3b7292493ba12787da593ae48cf261ea [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 12 tests failed, 148 tests passed.

Failures

❌ monotouch tests

12 tests failed, 8 tests passed.
Details
  • monotouch-test/tvOS - simulator/Debug [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Debug: Failed
  • monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Release (all optimizations) [dotnet]: Failed
  • monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar): Failed
  • monotouch-test/tvOS - simulator/Release (all optimizations): Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed

Html Report (VSDrops) Download

Successes

✅ bcl: All 59 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 5 tests passed. Html Report (VSDrops) Download
✅ framework: All 5 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 5 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 5 tests passed. Html Report (VSDrops) Download
✅ linker: All 38 tests passed. Html Report (VSDrops) Download
⚠️ mac_binding_project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
✅ mononative: All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. Html Report (VSDrops) Download
✅ xcframework: All 5 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
Copy link
Member

Test failures are unrelated (#15939).

@rolfbjarne rolfbjarne merged commit 5bce0b9 into dotnet:release/7.0.1xx-xcode14-rc2 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants