Skip to content

Use random file name for AutoML experiment folder #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinormont merged 2 commits into from
Jan 24, 2020
Merged

Use random file name for AutoML experiment folder #4657

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78368b8
Use random file name for AutoML experiment
jwood803 Jan 15, 2020
c9e6dbb
Prefix random file name with 'experiment'
jwood803 Jan 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/Microsoft.ML.AutoML/Experiment/Experiment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,19 +112,8 @@ private static DirectoryInfo GetModelDirectory(DirectoryInfo rootDir)
{
return null;
}
var subdirs = rootDir.Exists ?
new HashSet<string>(rootDir.EnumerateDirectories().Select(d => d.Name)) :
new HashSet<string>();
string experimentDir;
for (var i = 0; ; i++)
{
experimentDir = $"experiment{i}";
if (!subdirs.Contains(experimentDir))
{
break;
}
}
var experimentDirFullPath = Path.Combine(rootDir.FullName, experimentDir);

var experimentDirFullPath = Path.Combine(rootDir.FullName, Path.GetRandomFileName());
Copy link
Contributor

@justinormont justinormont Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you prefix w/ "experiment_"? The will help users know its purpose.

Suggested change
var experimentDirFullPath = Path.Combine(rootDir.FullName, Path.GetRandomFileName());
var experimentDirFullPath = Path.Combine(rootDir.FullName, "experiment_" + Path.GetRandomFileName());

This creates a path of Temp\Microsoft.ML.AutoML\experiment_w143kxnu.idj\....

Copy link
Contributor Author

@jwood803 jwood803 Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @justinormont! Added the prefix.

var experimentDirInfo = new DirectoryInfo(experimentDirFullPath);
if (!experimentDirInfo.Exists)
{
Expand Down