Skip to content

Conversation

@jwood803
Copy link
Contributor

Address #3803 by using a random file name when creating the AutoML experiment folder.

@jwood803 jwood803 requested a review from a team as a code owner January 15, 2020 11:32
}
var experimentDirFullPath = Path.Combine(rootDir.FullName, experimentDir);

var experimentDirFullPath = Path.Combine(rootDir.FullName, Path.GetRandomFileName());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you prefix w/ "experiment_"? The will help users know its purpose.

Suggested change
var experimentDirFullPath = Path.Combine(rootDir.FullName, Path.GetRandomFileName());
var experimentDirFullPath = Path.Combine(rootDir.FullName, "experiment_" + Path.GetRandomFileName());

This creates a path of Temp\Microsoft.ML.AutoML\experiment_w143kxnu.idj\....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @justinormont! Added the prefix.

Copy link
Contributor

@justinormont justinormont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'll merge once the CI tests pass. Most are passing hence I expect this is a random failure. MachineLearning-CI is the only remaining required test.

@justinormont justinormont merged commit c703cfe into dotnet:master Jan 24, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants