Skip to content

Parsing update for native header files with feature switch #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LakshanF merged 7 commits into from
May 21, 2021
Merged

Parsing update for native header files with feature switch #2044

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ca34f0
Parsing update for native header files with feature switch
LakshanF May 18, 2021
1ba1708
FB
LakshanF May 19, 2021
c303c20
fb
LakshanF May 20, 2021
198f984
FB
LakshanF May 20, 2021
1b3cb05
missed fb on one callsite location
LakshanF May 20, 2021
ae352cc
simpler hashcode to deal with a build break
LakshanF May 20, 2021
235876b
ran lint
LakshanF May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ILLink.Tasks/CreateRuntimeRootDescriptorFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,8 @@ void OutputXml (string iLLinkTrimXmlFilePath, string outputFileName)
featureDefault.Value = fsMembers.FeatureDefault;
featureAssemblyNode.Attributes.Append (featureDefault);

foreach (string typeName in featureSwitchMembers[fsMembers].Keys) {
AddXmlTypeNode (doc, featureAssemblyNode, typeName, featureSwitchMembers[fsMembers][typeName]);
foreach (var type in featureSwitchMembers[fsMembers]) {
AddXmlTypeNode (doc, featureAssemblyNode, type.Key, type.Value);
}
linkerNode.AppendChild (featureAssemblyNode);
}
Expand Down