Parsing update for native header files with feature switch #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoatr
reviewed
May 18, 2021
vitek-karas
reviewed
May 19, 2021
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
Please add tests. (There is an existing test already, so adding to it or adding a new one should not be that hard)
vitek-karas
reviewed
May 20, 2021
vitek-karas
reviewed
May 20, 2021
vitek-karas
reviewed
May 20, 2021
sbomer
reviewed
May 20, 2021
Member
mateoatr
reviewed
May 20, 2021
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Parsing update for native header files with feature switch Commit migrated from dotnet/linker@4526d38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to parse native header files that have the feature switch macro defined. Should be a no-op if the feature switch macro is not defined in a header file