-
Notifications
You must be signed in to change notification settings - Fork 172
Enable source-build prebuilt detection #1821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4a6444a
Initial enablement of source-build prebuilt detection
MichaelSimons cf55af0
Update nuget.config
MichaelSimons 7488313
workaround https://github.com/dotnet/source-build/issues/3392
MichaelSimons 0e41535
Update dependencies
MichaelSimons ef3b3b9
Fixups
MichaelSimons ef303cf
Revert to a single roslyn version property
MichaelSimons db09350
Merge branch 'main' into prebuilt-detection
MichaelSimons 6419ccb
Merge branch 'main' into prebuilt-detection
MichaelSimons 9ccec0f
Merge branch 'main' into prebuilt-detection
MichaelSimons File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| <UsageData> | ||
| <IgnorePatterns> | ||
| <UsagePattern IdentityGlob="*/*" /> | ||
| <UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*/*" /> | ||
|
|
||
| <!-- This is a transitive dependency from Microsoft.CodeAnalysis. | ||
| This version does not have source build intermediate. | ||
| When a newer version is picked up, the intermediate should be utilized. --> | ||
| <UsagePattern IdentityGlob="Microsoft.CodeAnalysis.AnalyzerUtilities/*3.3.0*" /> | ||
| </IgnorePatterns> | ||
| </UsageData> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,55 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Dependencies> | ||
| <ProductDependencies> | ||
| <Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.7.0-1.23226.15"> | ||
| <Dependency Name="Microsoft.CodeAnalysis" Version="4.7.0-1.23226.15"> | ||
| <Uri>https://github.com/dotnet/roslyn</Uri> | ||
| <Sha>56393223b78d294bccec3101e79dc03e1b3cb683</Sha> | ||
| <SourceBuild RepoName="roslyn" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-externals" Version="8.0.0-alpha.1.23221.1"> | ||
| <Uri>https://github.com/dotnet/source-build-externals</Uri> | ||
| <Sha>834923aef31d157aec19a2b99d5494cea29dcc9e</Sha> | ||
| <SourceBuild RepoName="source-build-externals" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="8.0.0-alpha.1.23253.2"> | ||
| <Uri>https://github.com/dotnet/source-build-reference-packages</Uri> | ||
| <Sha>c65b02aef21850de618d37a5304d3bbd829c2733</Sha> | ||
| <SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.DiaSymReader" Version="2.0.0-beta-22503-02"> | ||
| <Uri>https://github.com/dotnet/symreader</Uri> | ||
| <Sha>0c29b7109c054bdc578e917515ae7e8635b9cb9d</Sha> | ||
| <SourceBuild RepoName="symreader" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.SourceBuild.Intermediate.command-line-api" Version="0.1.356401"> | ||
| <Uri>https://github.com/dotnet/command-line-api</Uri> | ||
| <Sha>8374d5fca634a93458c84414b1604c12f765d1ab</Sha> | ||
| <SourceBuild RepoName="command-line-api" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <Dependency Name="System.CommandLine" Version="2.0.0-beta4.22564.1"> | ||
| <Uri>https://github.com/dotnet/command-line-api</Uri> | ||
| <Sha>350a618ab44932c568ae2392d7a571281baed59a</Sha> | ||
| <Sha>8374d5fca634a93458c84414b1604c12f765d1ab</Sha> | ||
| </Dependency> | ||
| <Dependency Name="System.CommandLine.Rendering" Version="0.4.0-alpha.22564.1"> | ||
| <Uri>https://github.com/dotnet/command-line-api</Uri> | ||
| <Sha>350a618ab44932c568ae2392d7a571281baed59a</Sha> | ||
| <Sha>8374d5fca634a93458c84414b1604c12f765d1ab</Sha> | ||
| </Dependency> | ||
| </ProductDependencies> | ||
| <ToolsetDependencies> | ||
| <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.23265.1"> | ||
| <Uri>https://github.com/dotnet/arcade</Uri> | ||
| <Sha>2d8d59065b5e090584a8e90c4371fc06ed60bdc5</Sha> | ||
| <SourceBuild RepoName="arcade" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.SourceLink.GitHub" Version="8.0.0-beta.23218.3" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk"> | ||
| <Uri>https://github.com/dotnet/sourcelink</Uri> | ||
| <Sha>47c52dd2ebf9edfd40abdcff999c13eb461f6ce2</Sha> | ||
| <SourceBuild RepoName="sourcelink" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.DotNet.XliffTasks" Version="1.0.0-beta.23263.1" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk"> | ||
| <Uri>https://github.com/dotnet/xliff-tasks</Uri> | ||
| <Sha>3f7d6c7e742012d9437fcb0d04cac63202d37621</Sha> | ||
| <SourceBuild RepoName="xliff-tasks" ManagedOnly="true" /> | ||
| </Dependency> | ||
| </ToolsetDependencies> | ||
| </Dependencies> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to remove these after P4 when sourcelink will be part of the sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must be living under a rock - this is news to me. If that's the case, then yes all sourcelink dependencies would have to be removed as well as removing the sourcelink repo from the VMR.
Can you point me to an issue for this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotnet/sdk#31632, cc @tmat