Fixed lazy loading thread safety #35529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added sync for lazy loading Fixes #35528
Contributor
Author
|
@dotnet-policy-service agree |
henriquewr
commented
Jan 25, 2025
Added tests for lazy loading thread safety
Member
|
@henriquewr Could you explain what the issue in the original code was? It seems that it made some incorrect assumption, but I don't see what it was exactly |
Member
|
Oh, I see. While it prevented a second thread from loading it didn't make it wait for the first thread to finish. |
Contributor
Author
|
@AndriySvyryd Exacly that what i was going to say |
fixed async lazy loading
|
|
||
| if (exists) | ||
| { | ||
| if (isLoadingValue.Depth.Value == 1) |
Member
There was a problem hiding this comment.
This is an interesting optimization. It definitely warrants a comment on how it works as the next person to read this code will be very confused.
@roji @cincuranet What's your opinion of this usage of AsyncLocal?
Member
|
Thanks for your contribution! |
Contributor
Author
|
You're welcome, I'm happy to contribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sync for lazy loading
Fixes #35528