Repository navigation
[Mono.Android] Fix AgentIcon namespace casing - #12815
Merged
jonathanpeppers merged 1 commit intoSep 17, 2026
Merged
jonathanpeppers merged 1 commit into
jonathanpeppers merged 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
simonrozsival
approved these changes
Sep 17, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates Android API 37.2 binding metadata to map android.agenticon to managed Android.AgentIcon while preserving the Java/JNI package identity.
Changes:
- Adds the
agenticon→AgentIconnamespace replacement. - Preserves the original Java package mapping.
File summaries
| File | Description |
|---|---|
src/Mono.Android/metadata |
Adds the AgentIcon namespace replacement. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
Member
Author
|
Verified the actual unsigned NuGet artifacts published by Azure DevOps build 1601030, built from merge commit Inspected
Both assemblies contain all four expected |
jonathanpeppers
added a commit
to dotnet/android-api-docs
that referenced
this pull request
Sep 17, 2026
Update generated API documentation to match the Android.AgentIcon namespace introduced by dotnet/android#12815. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
added a commit
to dotnet/android-api-docs
that referenced
this pull request
Sep 17, 2026
## Summary - regenerate .NET for Android API documentation for Android API/platform 37.2 - use the .NET 11 API-browser product moniker `net-android-37.0` - preserve Android platform availability at `android37.2` - preserve genuine 37.2 types, members, signatures, documentation, and API-level markers - import Android 37.2 sources/Javadocs using the 37.2 binding profile - exclude broad generator attribute normalization unrelated to API 37.2 - restore base XML serialization for retained nodes to remove formatting/reflow churn - use the corrected `Android.AgentIcon` namespace from dotnet/android#12815, including framework inventory, namespace mapping, cross-namespace signatures, and generated enum signatures ## Scope - GitHub reports 499 changed files, 77,346 insertions, and 410 deletions against android-api-docs main `b867947703edcaece3c2a055ae6ea01847cae68f` - framework inventory is `docs/xml/FrameworksIndex/net-android-37.0.xml` with `<Framework Name="net-android-37.0">` - no generated `FrameworkAlternate` uses the Android SDK minor version; retained `net-android-36.0` alternates remain historical .NET 10 metadata - restored historical types/members and meaningful documentation still required by older product inventories - excluded unrelated API <=24 obsoletion normalization and serialization-only churn ## AgentIcon dependency The latest commit assumes dotnet/android#12815 merges before this documentation update. It changes only the managed namespace token and paths from `Android.Agenticon` to `Android.AgentIcon`; after reversing that token, all 16 touched files are byte-identical to their prior content (with checkout line endings normalized). The actual unsigned packages from Azure DevOps build [1601030](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1601030), source merge commit `9bc18c75acd8945015e14e460f067a75f32ec20f`, were independently inspected: - `Microsoft.Android.Ref.37.2.37.2.0-ci.pr.gh12815.0.nupkg` (`SHA256 E59D0C92E32D5A9E14CEBF7A72CD1BE4CDD839D7D0C25464A9C83C9C1F23AA46`) - `Microsoft.Android.Runtime.37.2.android.37.2.0-ci.pr.gh12815.0.nupkg` (`SHA256 7F05BEDA55BE709A78AF163A91EF5C98F38A3CB2218146883CDB0E29D7D0AE95`) Both `Mono.Android.dll` assemblies contain the four expected top-level `Android.AgentIcon` types and their nested builders/interface constants, zero exact `Android.Agenticon` definitions or references, the `android.agenticon` Java namespace mapping, `StatusBarManager` references to `Android.AgentIcon`, and all four enumified `WriteToParcel(..., Android.OS.ParcelableWriteFlags)` signatures. ## Validation - parsed all 11,079 XML files with zero errors - framework inventory contains 10,697 unique type IDs and 135,578 unique member IDs - zero duplicate inventory type/member IDs - zero type/member-node DocId collisions, including AgentIcon - zero references to `Android.Agenticon` or the incorrect `net-android-37.2.0` moniker - exactly one `android.agenticon` to `Android.AgentIcon` namespace mapping - Android availability remains `android37.2` - existing meaningful documentation and all 282 pre-existing placeholders in the touched API files are unchanged - `git diff --check` passes ## Learn moniker `net-android-37.0` is centrally registered with Learn. For future Android documentation monikers, use [OPS Monikers](https://ops.microsoft.com/#/monikers), select **Request-Monikers**, and use platform `Dotnet`; see the [Learn moniker help](https://review.learn.microsoft.com/en-us/help/onboard/versions-monikers?branch=main#request-a-moniker). The .NET Android API Docs Publishing runbook names Dave Britch as the contact. Generated from dotnet/android parent `261d2ce4894cb33942179f113f723eb6ec22f011`, with the AgentIcon namespace output validated against dotnet/android#12815 CI binaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android API 37.2 currently generates the Java
android.agenticonpackage as the managed namespaceAndroid.Agenticon. Add the namespace replacement metadata so bindings and documentation consistently useAndroid.AgentIconwhile preserving the Java/JNI package identity.Validation:
build.cmd Preparedotnet-local.cmd build src\Mono.Android\Mono.Android.csproj -c Debug -p:AndroidApiLevel=37.2 -p:AndroidPlatformId=37.2 -p:AndroidFrameworkVersion=v17.2 -p:IncludeAndroidJavadoc=False -nodeReuse:falseStatusBarManagerreferences, namespace mapping, and enumifiedParcelableWriteFlagssignatures useAndroid.AgentIcon, with no managedAndroid.Agenticonremaining.