Skip to content

[Mono.Android] Fix AgentIcon namespace casing - #12815

Merged
jonathanpeppers merged 1 commit into
dotnet:mainfrom
jonathanpeppers:jonathanpeppers-fix-agenticon-casing
Sep 17, 2026
Merged

jonathanpeppers merged 1 commit into
dotnet:mainfrom
jonathanpeppers:jonathanpeppers-fix-agenticon-casing

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Android API 37.2 currently generates the Java android.agenticon package as the managed namespace Android.Agenticon. Add the namespace replacement metadata so bindings and documentation consistently use Android.AgentIcon while preserving the Java/JNI package identity.

Validation:

  • build.cmd Prepare
  • dotnet-local.cmd build src\Mono.Android\Mono.Android.csproj -c Debug -p:AndroidApiLevel=37.2 -p:AndroidPlatformId=37.2 -p:AndroidFrameworkVersion=v17.2 -p:IncludeAndroidJavadoc=False -nodeReuse:false
  • Verified all four generated AgentTask types, StatusBarManager references, namespace mapping, and enumified ParcelableWriteFlags signatures use Android.AgentIcon, with no managed Android.Agenticon remaining.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 17, 2026 14:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Updates Android API 37.2 binding metadata to map android.agenticon to managed Android.AgentIcon while preserving the Java/JNI package identity.

Changes:

  • Adds the agenticon → AgentIcon namespace replacement.
  • Preserves the original Java package mapping.
File summaries
File Description
src/Mono.Android/metadata Adds the AgentIcon namespace replacement.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

@jonathanpeppers

Copy link
Copy Markdown
Member Author

Verified the actual unsigned NuGet artifacts published by Azure DevOps build 1601030, built from merge commit 9bc18c75 containing this PR commit.

Inspected Mono.Android.dll from both:

  • Microsoft.Android.Ref.37.2.37.2.0-ci.pr.gh12815.0.nupkg
  • Microsoft.Android.Runtime.37.2.android.37.2.0-ci.pr.gh12815.0.nupkg

Both assemblies contain all four expected Android.AgentIcon types (AgentTaskEvent, AgentTaskOutcome, AgentTaskState, and AgentTaskUpdate) and contain zero type definitions or references using Android.Agenticon.

jonathanpeppers added a commit to dotnet/android-api-docs that referenced this pull request Sep 17, 2026
Update generated API documentation to match the Android.AgentIcon namespace introduced by dotnet/android#12815.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers merged commit c6ee081 into dotnet:main Sep 17, 2026
42 of 44 checks passed
jonathanpeppers added a commit to dotnet/android-api-docs that referenced this pull request Sep 17, 2026
## Summary

- regenerate .NET for Android API documentation for Android API/platform 37.2
- use the .NET 11 API-browser product moniker `net-android-37.0`
- preserve Android platform availability at `android37.2`
- preserve genuine 37.2 types, members, signatures, documentation, and API-level markers
- import Android 37.2 sources/Javadocs using the 37.2 binding profile
- exclude broad generator attribute normalization unrelated to API 37.2
- restore base XML serialization for retained nodes to remove formatting/reflow churn
- use the corrected `Android.AgentIcon` namespace from dotnet/android#12815, including framework inventory, namespace mapping, cross-namespace signatures, and generated enum signatures

## Scope

- GitHub reports 499 changed files, 77,346 insertions, and 410 deletions against android-api-docs main `b867947703edcaece3c2a055ae6ea01847cae68f`
- framework inventory is `docs/xml/FrameworksIndex/net-android-37.0.xml` with `<Framework Name="net-android-37.0">`
- no generated `FrameworkAlternate` uses the Android SDK minor version; retained `net-android-36.0` alternates remain historical .NET 10 metadata
- restored historical types/members and meaningful documentation still required by older product inventories
- excluded unrelated API <=24 obsoletion normalization and serialization-only churn

## AgentIcon dependency

The latest commit assumes dotnet/android#12815 merges before this documentation update. It changes only the managed namespace token and paths from `Android.Agenticon` to `Android.AgentIcon`; after reversing that token, all 16 touched files are byte-identical to their prior content (with checkout line endings normalized).

The actual unsigned packages from Azure DevOps build [1601030](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1601030), source merge commit `9bc18c75acd8945015e14e460f067a75f32ec20f`, were independently inspected:

- `Microsoft.Android.Ref.37.2.37.2.0-ci.pr.gh12815.0.nupkg` (`SHA256 E59D0C92E32D5A9E14CEBF7A72CD1BE4CDD839D7D0C25464A9C83C9C1F23AA46`)
- `Microsoft.Android.Runtime.37.2.android.37.2.0-ci.pr.gh12815.0.nupkg` (`SHA256 7F05BEDA55BE709A78AF163A91EF5C98F38A3CB2218146883CDB0E29D7D0AE95`)

Both `Mono.Android.dll` assemblies contain the four expected top-level `Android.AgentIcon` types and their nested builders/interface constants, zero exact `Android.Agenticon` definitions or references, the `android.agenticon` Java namespace mapping, `StatusBarManager` references to `Android.AgentIcon`, and all four enumified `WriteToParcel(..., Android.OS.ParcelableWriteFlags)` signatures.

## Validation

- parsed all 11,079 XML files with zero errors
- framework inventory contains 10,697 unique type IDs and 135,578 unique member IDs
- zero duplicate inventory type/member IDs
- zero type/member-node DocId collisions, including AgentIcon
- zero references to `Android.Agenticon` or the incorrect `net-android-37.2.0` moniker
- exactly one `android.agenticon` to `Android.AgentIcon` namespace mapping
- Android availability remains `android37.2`
- existing meaningful documentation and all 282 pre-existing placeholders in the touched API files are unchanged
- `git diff --check` passes

## Learn moniker

`net-android-37.0` is centrally registered with Learn. For future Android documentation monikers, use [OPS Monikers](https://ops.microsoft.com/#/monikers), select **Request-Monikers**, and use platform `Dotnet`; see the [Learn moniker help](https://review.learn.microsoft.com/en-us/help/onboard/versions-monikers?branch=main#request-a-moniker). The .NET Android API Docs Publishing runbook names Dave Britch as the contact.

Generated from dotnet/android parent `261d2ce4894cb33942179f113f723eb6ec22f011`, with the AgentIcon namespace output validated against dotnet/android#12815 CI binaries.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants