Repository navigation
[API 37.2] Regenerate .NET for Android API documentation - #681
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Fourteen final documentation findings remain unresolved, including inaccurate, malformed, and ungrammatical API text.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Regenerates .NET for Android API documentation for Android API 37.2, importing updated sources and Javadocs while preserving substantive documentation and removing duplicate generated entries.
Changes:
- Updates API metadata, namespaces, member documentation, and formatting.
- Adds newly surfaced API 37.2 namespace documentation.
- Validates all 11,078 XML files with no duplicate DocIds or signatures.
File summaries
| File | Reviewed change |
|---|---|
docs/xml/Org.XmlPull.V1/XmlPullParserFactory.xml |
nit (3 votes): Align the summary with the XmlPullParserFactory return type. |
docs/xml/Org.Xml.Sax.Ext/Attributes2Impl.xml |
nit (3 votes): Restore the usable IsDeclared(int) summary. |
docs/xml/Org.W3c.Dom.LS/ILSInput.xml |
Reviewed. |
docs/xml/Org.Apache.Http/IHttpStatus.xml |
Reviewed. |
docs/xml/Org.Apache.Http/IHttpRequest.xml |
Reviewed. |
docs/xml/Org.Apache.Http/IHttpEntityExtensions.xml |
Reviewed. |
docs/xml/Org.Apache.Http/IHttpConnection.xml |
Reviewed. |
docs/xml/Org.Apache.Http/IHeaderIterator.xml |
Reviewed. |
docs/xml/Org.Apache.Http/IFormattedHeader.xml |
Reviewed. |
docs/xml/Org.Apache.Http.IO/IHttpMessageWriterExtensions.xml |
Reviewed. |
docs/xml/Org.Apache.Http.IO/IHttpMessageParserExtensions.xml |
Reviewed. |
docs/xml/Org.Apache.Http.Conn/IManagedClientConnectionExtensions.xml |
Reviewed. |
docs/xml/Org.Apache.Http.Conn.Schemes/ISocketFactoryExtensions.xml |
Reviewed. |
docs/xml/Org.Apache.Http.Conn.Schemes/ILayeredSocketFactoryExtensions.xml |
Reviewed. |
docs/xml/Org.Apache.Http.Client/IResponseHandler.xml |
Reviewed. |
docs/xml/ns-Android.Util.Function.xml |
Reviewed. |
docs/xml/ns-Android.Service.PersonalContext.Understander.xml |
Reviewed. |
docs/xml/ns-Android.Service.PersonalContext.Insight.xml |
Reviewed. |
docs/xml/ns-Android.Service.PersonalContext.Insight.Interaction.xml |
Reviewed. |
docs/xml/ns-Android.Service.PersonalContext.Embedded.xml |
Reviewed. |
docs/xml/ns-Android.Service.ContentSafety.xml |
Reviewed. |
docs/xml/ns-Android.Security.Net.Config.xml |
Reviewed. |
docs/xml/ns-Android.Security.AuthenticationPolicy.xml |
Reviewed. |
docs/xml/ns-Android.OS.MultiSensory.xml |
Reviewed. |
docs/xml/ns-Android.Hardware.Hid.xml |
Reviewed. |
docs/xml/ns-Android.App.Time.xml |
Reviewed. |
docs/xml/ns-Android.App.PersonalContext.xml |
Reviewed. |
docs/xml/ns-Android.App.PersonalContext.Understander.xml |
Reviewed. |
docs/xml/ns-Android.App.PersonalContext.Insight.xml |
Reviewed. |
docs/xml/ns-Android.App.PersonalContext.Insight.Interaction.xml |
Reviewed. |
docs/xml/ns-Android.App.PersonalContext.Hint.xml |
Reviewed. |
docs/xml/ns-Android.App.ContentSafety.xml |
Reviewed. |
docs/xml/ns-Android.App.Admin.Policy.xml |
Reviewed. |
docs/xml/ns-Android.Agenticon.xml |
Reviewed. |
docs/xml/Javax.Xml.Parsers/SAXParserFactory.xml |
nit (3 votes): Restore the feature-oriented summary and documentation for GetFeature. |
docs/xml/Javax.Xml.Datatype/XMLGregorianCalendar.xml |
Reviewed. |
docs/xml/Javax.Xml.Datatype/DatatypeFactory.xml |
nit (3 votes): Correct the NewInstance return description to name DatatypeFactory. |
docs/xml/Javax.Net.Ssl/SSLSocket.xml |
Reviewed. |
docs/xml/Javax.Net.Ssl/SSLEngine.xml |
Reviewed. |
docs/xml/Java.Util/TreeSet.xml |
Reviewed. |
docs/xml/Java.Util/TimeZone.xml |
Reviewed. |
docs/xml/Java.Util/LinkedList.xml |
Reviewed. |
docs/xml/Java.Util/ISet.xml |
Reviewed. |
docs/xml/Java.Util/IPrimitiveIterator.xml |
Reviewed. |
docs/xml/Java.Util/IIterator.xml |
Reviewed. |
docs/xml/Java.Util/HashSet.xml |
Reviewed. |
docs/xml/Java.Util/GregorianCalendar.xml |
Reviewed. |
docs/xml/Java.Util/EventListenerProxy.xml |
Reviewed. |
docs/xml/Java.Util/Currency.xml |
Reviewed. |
docs/xml/Java.Util/ArrayDeque.xml |
Reviewed. |
docs/xml/Java.Util.Zip/ZipOutputStream.xml |
Reviewed. |
docs/xml/Java.Util.Zip/ZipInputStream.xml |
Reviewed. |
docs/xml/Java.Util.Zip/InflaterInputStream.xml |
Reviewed. |
docs/xml/Java.Util.Streams/StreamSupport.xml |
Reviewed. |
docs/xml/Java.Util.Streams/Gatherer.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IUnaryOperator.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IToLongFunction.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IToLongBiFunction.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IToIntFunction.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IToIntBiFunction.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IToDoubleFunction.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IToDoubleBiFunction.xml |
Reviewed. |
docs/xml/Java.Util.Functions/ISupplier.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IObjLongConsumer.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IObjIntConsumer.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IObjDoubleConsumer.xml |
Reviewed. |
docs/xml/Java.Util.Functions/ILongFunction.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IIntFunction.xml |
Reviewed. |
docs/xml/Java.Util.Functions/IDoubleFunction.xml |
Reviewed. |
docs/xml/Java.Util.Concurrent/SynchronousQueue.xml |
Reviewed. |
docs/xml/Java.Util.Concurrent/PriorityBlockingQueue.xml |
Reviewed. |
docs/xml/Java.Util.Concurrent/LinkedTransferQueue.xml |
Reviewed. |
docs/xml/Java.Util.Concurrent/LinkedBlockingQueue.xml |
Reviewed. |
docs/xml/Java.Util.Concurrent/ConcurrentLinkedQueue.xml |
Reviewed. |
docs/xml/Java.Util.Concurrent/ConcurrentLinkedDeque.xml |
Reviewed. |
docs/xml/Java.Util.Concurrent/ArrayBlockingQueue.xml |
Reviewed. |
docs/xml/Java.Util.Concurrent.Atomic/Striped64.xml |
Reviewed. |
docs/xml/Java.Time/ZoneOffset.xml |
Reviewed. |
docs/xml/Java.Time.Format/TextStyle.xml |
nit (3 votes): Restore the usable summary and return text for asStandalone(). |
docs/xml/Java.Text/AttributedCharacterIteratorAttribute.xml |
Reviewed. |
docs/xml/Java.Security.Cert/X509CRLEntry.xml |
Reviewed. |
docs/xml/Java.Security.Cert/X509Certificate.xml |
Reviewed. |
docs/xml/Java.Security.Cert/CertPathValidatorSpi.xml |
Reviewed. |
docs/xml/Java.Security.Cert/CertPathValidator.xml |
Reviewed. |
docs/xml/Java.Security.Cert/CertPathBuilderSpi.xml |
Reviewed. |
docs/xml/Java.Security.Cert/CertPathBuilder.xml |
Reviewed. |
docs/xml/Java.Nio.FileNio/FileSystems.xml |
Reviewed. |
docs/xml/Java.Nio.FileNio/FileStore.xml |
Reviewed. |
docs/xml/Java.Nio.FileNio/Files.xml |
Reviewed. |
docs/xml/Java.Nio.Channels/Selector.xml |
Reviewed. |
docs/xml/Java.Nio.Channels/SelectionKey.xml |
Reviewed. |
docs/xml/Java.Nio.Channels/IChannel.xml |
Reviewed. |
docs/xml/Java.Net/URLClassLoader.xml |
Reviewed. |
docs/xml/Java.Net/IProtocolFamily.xml |
Reviewed. |
docs/xml/Java.Lang/Throwable.xml |
Reviewed. |
docs/xml/Java.Lang/Object.xml |
Reviewed. |
docs/xml/Java.Lang/Error.xml |
Reviewed. |
docs/xml/Java.Lang/ClassLoader.xml |
Reviewed. |
docs/xml/Java.Lang/AbstractStringBuilder.xml |
Reviewed. |
docs/xml/Java.Lang.Reflect/Method.xml |
Reviewed. |
docs/xml/Java.Lang.Reflect/Field.xml |
Reviewed. |
docs/xml/Java.Lang.Reflect/Constructor.xml |
Reviewed. |
docs/xml/Java.Lang.Annotation/IRepeatable.xml |
Reviewed. |
docs/xml/Java.IO/InputStreamReader.xml |
Reviewed. |
docs/xml/Java.IO/CharArrayReader.xml |
Reviewed. |
docs/xml/Java.Interop/JniNativeMethod.xml |
Reviewed. |
docs/xml/Java.Interop/JniMethodSignatureAttribute.xml |
Reviewed. |
docs/xml/Java.Interop/JniConstructorSignatureAttribute.xml |
Reviewed. |
docs/xml/Java.Interop/JniAddNativeMethodRegistrationAttribute.xml |
Reviewed. |
docs/xml/Android.Window/SystemOnBackInvokedCallbacks.xml |
nit (3 votes): Change to triggers to to trigger. |
docs/xml/Android.Widget/ZoomButtonsController.xml |
Reviewed. |
docs/xml/Android.Widget/RelativeLayout+LayoutParams.xml |
Reviewed. |
docs/xml/Android.Widget/QuickContactBadge.xml |
Reviewed. |
docs/xml/Android.Widget/ProgressBar.xml |
Reviewed. |
docs/xml/Android.Widget/ListView.xml |
Reviewed. |
docs/xml/Android.Widget/ListPopupWindow.xml |
Reviewed. |
docs/xml/Android.Widget/LinearLayout.xml |
Reviewed. |
docs/xml/Android.Widget/ImageView.xml |
Reviewed. |
docs/xml/Android.Widget/FrameLayout+LayoutParams.xml |
Reviewed. |
docs/xml/Android.Widget/CompoundButton.xml |
Reviewed. |
docs/xml/Android.Widget/AutoCompleteTextView.xml |
Reviewed. |
docs/xml/Android.Webkit/WebIconDatabase.xml |
Reviewed. |
docs/xml/Android.Webkit/PermissionRequest.xml |
Reviewed. |
docs/xml/Android.Webkit/CookieManager.xml |
Reviewed. |
docs/xml/Android.Views/WindowManagerTypes.xml |
Reviewed. |
docs/xml/Android.Views/WindowManagerFlags.xml |
Reviewed. |
docs/xml/Android.Views/WindowInsets+Type.xml |
Reviewed. |
docs/xml/Android.Views/Window+IOnRestrictedCaptionAreaChangedListener.xml |
Reviewed. |
docs/xml/Android.Views/Window+IOnFrameMetricsAvailableListener.xml |
Reviewed. |
docs/xml/Android.Views/View+IOnScrollChangeListener.xml |
Reviewed. |
docs/xml/Android.Views/View+IOnContextClickListener.xml |
Reviewed. |
docs/xml/Android.Views/View+BaseSavedState.xml |
Reviewed. |
docs/xml/Android.Views/SystemUiFlags.xml |
Reviewed. |
docs/xml/Android.Views/InputSourceType.xml |
Reviewed. |
docs/xml/Android.Views/HapticFeedbackConstants.xml |
Reviewed. |
docs/xml/Android.Views/GestureDetector+SimpleOnGestureListener.xml |
Reviewed. |
docs/xml/Android.Views/GestureDetector+IOnContextClickListener.xml |
Reviewed. |
docs/xml/Android.Views/FeedbackConstants.xml |
Reviewed. |
docs/xml/Android.Views/DisplayFlags.xml |
Reviewed. |
docs/xml/Android.Views/ContextThemeWrapper.xml |
Reviewed. |
docs/xml/Android.Views/Choreographer+IFrameCallback.xml |
Reviewed. |
docs/xml/Android.Views/AbsSavedState.xml |
Reviewed. |
docs/xml/Android.Views.Translation/TranslationCapability.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextSelection+Request+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextSelection+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextLinks+TextLink+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextLinks+Request+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextLinks+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextLanguage+Request+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextLanguage+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextClassifierEvent+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextClassifierEntityConfig+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextClassificationSessionId+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextClassificationContext+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextClassification+Request+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/TextClassification+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/SelectionEvent+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/ConversationActions+Request+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/ConversationActions+Message+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/ConversationActions+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.TextClassifiers/ConversationAction+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.InputMethods/CompletionInfo.xml |
Reviewed. |
docs/xml/Android.Views.Accessibility/AccessibilityNodeInfo+SelectionPosition+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.Accessibility/AccessibilityNodeInfo+Selection+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Views.Accessibility/AccessibilityNodeInfo+CollectionItemInfo.xml |
Reviewed. |
docs/xml/Android.Views.Accessibility/AccessibilityManager.xml |
Reviewed. |
docs/xml/Android.Util/JsonReader.xml |
Reviewed. |
docs/xml/Android.Transitions/TransitionManager.xml |
Reviewed. |
docs/xml/Android.Transitions/TransitionInflater.xml |
Reviewed. |
docs/xml/Android.Transitions/ChangeBounds.xml |
Reviewed. |
docs/xml/Android.Text/InputType.xml |
nit (2 votes): Retain the Android.Text.InputTypes obsolete target. |
docs/xml/Android.Text.Style/RasterizerSpan.xml |
nit (3 votes): Correct accerlerated to hardware-accelerated. |
docs/xml/Android.Test/IUiThreadTest.xml |
Reviewed. |
docs/xml/Android.Test/IPerformanceTestCase.xml |
Reviewed. |
docs/xml/Android.Test/IFlakyTest.xml |
Reviewed. |
docs/xml/Android.Telephony/SignalStrength.xml |
Reviewed. |
docs/xml/Android.Telephony/ParsedPhoneNumber+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Telephony/CellIdentityWcdma.xml |
Reviewed. |
docs/xml/Android.Telephony/CellIdentityLte.xml |
Reviewed. |
docs/xml/Android.Telephony.Satellite/SatelliteManager.xml |
Reviewed. |
docs/xml/Android.Telephony.Ims/ImsRegistrationAttributes.xml |
Reviewed. |
docs/xml/Android.Telecom/Conferenceable.xml |
Reviewed. |
docs/xml/Android.Telecom/Call+RttCall.xml |
Reviewed. |
docs/xml/Android.Systems/StructUtsname.xml |
Reviewed. |
docs/xml/Android.Speech/RecognizerIntent.xml |
Reviewed. |
docs/xml/Android.Speech/RecognitionService+Callback.xml |
Reviewed. |
docs/xml/Android.Service.Chooser/ChooserSessionToken+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Service.Carrier/CarrierMessagingService+IResultCallback.xml |
Reviewed. |
docs/xml/Android.Service.Autofill/Presentations.xml |
Reviewed. |
docs/xml/Android.Renderscripts/ScriptGroup+Input.xml |
Reviewed. |
docs/xml/Android.Renderscripts/ScriptGroup+Future.xml |
Reviewed. |
docs/xml/Android.Renderscripts/Script+InvokeID.xml |
Reviewed. |
docs/xml/Android.Renderscripts/ProgramStore.xml |
Reviewed. |
docs/xml/Android.Renderscripts/Program.xml |
Reviewed. |
docs/xml/Android.Renderscripts/Element+DataType.xml |
Reviewed. |
docs/xml/Android.Ranging/RangingSession.xml |
nit (2 votes): Restore the RequiresPermission("android.permission.RANGING") attributes on Start. |
docs/xml/Android.Ranging.Wifi.Rtt/RttStationRangingParams+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Ranging.Oob/OobInitiatorRangingConfig.xml |
Reviewed. |
docs/xml/Android.Provider/VoicemailContract.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+TextBasedSmsColumns.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Sms+Sent+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Sms+Outbox+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Sms+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Sms+Inbox+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Sms+Draft+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Sms+Conversations+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Mms+Sent+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Mms+Outbox+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Mms+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Mms+Inbox+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Mms+Draft+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+ITextBasedSmsColumns.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+IBaseMmsColumns.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+Carriers.xml |
Reviewed. |
docs/xml/Android.Provider/Telephony+BaseMmsColumns.xml |
Reviewed. |
docs/xml/Android.Provider/ContactsContract+DisplayNameSources.xml |
Reviewed. |
docs/xml/Android.Provider/CloudMediaProviderContract+Capabilities.xml |
Reviewed. |
docs/xml/Android.Print/PrinterCapabilitiesInfo+Builder.xml |
Reviewed. |
docs/xml/Android.Print/PrinterCapabilitiesInfo.xml |
Reviewed. |
docs/xml/Android.Print/PrintAttributes+Builder.xml |
Reviewed. |
docs/xml/Android.Print/PrintAttributes.xml |
Reviewed. |
docs/xml/Android.OS/VibrationAttributes.xml |
Reviewed. |
docs/xml/Android.OS/UserHandle.xml |
Reviewed. |
docs/xml/Android.OS/TransactionTooLargeException.xml |
Reviewed. |
docs/xml/Android.OS/RecoverySystem.xml |
Reviewed. |
docs/xml/Android.OS/ProfilingManager.xml |
Reviewed. |
docs/xml/Android.OS/MessageQueue+IOnFileDescriptorEventListener.xml |
Reviewed. |
docs/xml/Android.OS/Environment.xml |
Reviewed. |
docs/xml/Android.OS/DeadObjectException.xml |
Reviewed. |
docs/xml/Android.OS/CombinedVibration.xml |
Reviewed. |
docs/xml/Android.Opengl/GLSurfaceView.xml |
Reviewed. |
docs/xml/Android.Opengl/GLES32+IDebugProc.xml |
Reviewed. |
docs/xml/Android.Nfc.CardEmulators/CardEmulation.xml |
Reviewed. |
docs/xml/Android.Net/VpnService+Builder.xml |
Reviewed. |
docs/xml/Android.Net/VpnService.xml |
Reviewed. |
docs/xml/Android.Net/SSLCertificateSocketFactory.xml |
Reviewed. |
docs/xml/Android.Net/Proxy.xml |
Reviewed. |
docs/xml/Android.Net/NetworkInfo.xml |
Reviewed. |
docs/xml/Android.Net/IpPrefix.xml |
Reviewed. |
docs/xml/Android.Net.Wifi/WifiManager.xml |
Reviewed. |
docs/xml/Android.Net.Wifi.P2p/WifiP2pManager.xml |
Reviewed. |
docs/xml/Android.Media/SuggestedDeviceInfo+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Media/MediaTrackType.xml |
Reviewed. |
docs/xml/Android.Media/MediaSync+IOnErrorListener.xml |
Reviewed. |
docs/xml/Android.Media/MediaRouter2+RoutingController.xml |
Reviewed. |
docs/xml/Android.Media/MediaRoute2ProviderService.xml |
Reviewed. |
docs/xml/Android.Media/MediaRecorder+VideoEncoder.xml |
Reviewed. |
docs/xml/Android.Media/MediaPlayer+TrackInfo.xml |
Reviewed. |
docs/xml/Android.Media/MediaPlayer+IOnTimedMetaDataAvailableListener.xml |
Reviewed. |
docs/xml/Android.Media/MediaDrm+IOnKeyStatusChangeListener.xml |
Reviewed. |
docs/xml/Android.Media/MediaDrm+IOnExpirationUpdateListener.xml |
Reviewed. |
docs/xml/Android.Media/MediaCrypto.xml |
Reviewed. |
docs/xml/Android.Media/MediaCommunicationManager.xml |
Reviewed. |
docs/xml/Android.Media/MediaCodecInfo+VideoCapabilities.xml |
Reviewed. |
docs/xml/Android.Media/MediaCodecCryptoMode.xml |
Reviewed. |
docs/xml/Android.Media/MediaCodec+IOnFrameRenderedListener.xml |
Reviewed. |
docs/xml/Android.Media/MediaCodec+CodecException.xml |
Reviewed. |
docs/xml/Android.Media/ImageWriter+IOnImageReleasedListener.xml |
Reviewed. |
docs/xml/Android.Media/IAudioRoutingOnRoutingChangedListener.xml |
Reviewed. |
docs/xml/Android.Media.TV/TvView+TvInputCallback.xml |
Reviewed. |
docs/xml/Android.Media.TV.Interactive/TvInteractiveAppView.xml |
Reviewed. |
docs/xml/Android.Media.TV.Interactive/TvInteractiveAppService+Session.xml |
Reviewed. |
docs/xml/Android.Media.Session/PlaybackState+Builder.xml |
Reviewed. |
docs/xml/Android.Media.Midi/MidiManager+IOnDeviceOpenedListener.xml |
Reviewed. |
docs/xml/Android.Locations/IOnNmeaMessageListener.xml |
Reviewed. |
docs/xml/Android.Icu.Text/Normalizer+QuickCheckResult.xml |
Reviewed. |
docs/xml/Android.Icu.Number/FormattedNumberRange.xml |
Reviewed. |
docs/xml/Android.Icu.Lang/UCharacterEnums.xml |
Reviewed. |
docs/xml/Android.Hardware/CameraError.xml |
Reviewed. |
docs/xml/Android.Hardware.Usb/UsbDevice.xml |
Reviewed. |
docs/xml/Android.Hardware.Display/DisplayTopology+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Hardware.Camera2/LensFacing.xml |
Reviewed. |
docs/xml/Android.Hardware.Camera2/InfoSupportedHardwareLevel.xml |
Reviewed. |
docs/xml/Android.Hardware.Camera2/EdgeMode.xml |
Reviewed. |
docs/xml/Android.Hardware.Camera2/ControlSceneMode.xml |
Reviewed. |
docs/xml/Android.Hardware.Camera2/ControlAEPrecaptureTrigger.xml |
Reviewed. |
docs/xml/Android.Hardware.Biometrics/FallbackOption+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Hardware.Biometrics/BiometricPrompt+CryptoObject.xml |
Reviewed. |
docs/xml/Android.Graphics/Rasterizer.xml |
nit (3 votes): Correct accerlerated to hardware-accelerated. |
docs/xml/Android.Graphics/LayerRasterizer.xml |
nit (3 votes): Correct accerlerated to hardware-accelerated. |
docs/xml/Android.Graphics.Pdf/PdfRendererPreV+Page.xml |
Reviewed. |
docs/xml/Android.Graphics.Pdf/PdfRenderer+Page.xml |
Reviewed. |
docs/xml/Android.Graphics.Pdf.Models/FormEditRecord+Builder.xml |
Reviewed. |
docs/xml/Android.Graphics.Drawables/Icon+IOnDrawableLoadedListener.xml |
Reviewed. |
docs/xml/Android.DeviceLock/DeviceLockManager.xml |
Reviewed. |
docs/xml/Android.DeviceLock/DeviceId.xml |
Reviewed. |
docs/xml/Android.Database.Sqlite/SQLiteDatabase.xml |
Reviewed. |
docs/xml/Android.Content/SyncRequest+Builder.xml |
Reviewed. |
docs/xml/Android.Content/RestrictionsManager.xml |
Reviewed. |
docs/xml/Android.Content/FileCreationMode.xml |
Reviewed. |
docs/xml/Android.Content/Bind.xml |
Reviewed. |
docs/xml/Android.Content/ActivityFlags.xml |
Reviewed. |
docs/xml/Android.Content.Res/TypedArray.xml |
Reviewed. |
docs/xml/Android.Content.Res/Resources+Theme.xml |
Reviewed. |
docs/xml/Android.Content.Res/Resources+NotFoundException.xml |
Reviewed. |
docs/xml/Android.Content.PM/ComponentInfo.xml |
Reviewed. |
docs/xml/Android.Content.PM.Verify.Domain/DomainVerificationUserState.xml |
Reviewed. |
docs/xml/Android.Content.OM/FabricatedOverlay.xml |
Reviewed. |
docs/xml/Android.Bluetooth/BluetoothGattServer+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.Bluetooth/BluetoothGatt.xml |
Reviewed. |
docs/xml/Android.Bluetooth/BluetoothClass+Service.xml |
Reviewed. |
docs/xml/Android.Bluetooth.LE/ScanSettings.xml |
Reviewed. |
docs/xml/Android.Bluetooth.LE/ScanMode.xml |
Reviewed. |
docs/xml/Android.Appwidget/AppWidgetEvent+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.App/UiAutomationFlags.xml |
Reviewed. |
docs/xml/Android.App/UiAutomation.xml |
Reviewed. |
docs/xml/Android.App/SharedElementCallback.xml |
Reviewed. |
docs/xml/Android.App/PendingIntentFlags.xml |
Reviewed. |
docs/xml/Android.App/NotificationChannel.xml |
Reviewed. |
docs/xml/Android.App/Notification+InboxStyle.xml |
Reviewed. |
docs/xml/Android.App/Notification+BigTextStyle.xml |
Reviewed. |
docs/xml/Android.App/FragmentManagerNonConfig.xml |
Reviewed. |
docs/xml/Android.App/AppOpsManager+IOnOpActiveChangedListener.xml |
Reviewed. |
docs/xml/Android.App/AlertDialog+Builder.xml |
Reviewed. |
docs/xml/Android.App.Usage/UsageEventType.xml |
Reviewed. |
docs/xml/Android.App.Job/TriggerContentUriFlags.xml |
Reviewed. |
docs/xml/Android.App.Job/NetworkType.xml |
Reviewed. |
docs/xml/Android.App.AppSearch/SearchResult+TextMatchInfo+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.App.AppSearch/SearchResult+MatchRange+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.App.AppSearch/SearchResult+EmbeddingMatchInfo+InterfaceConsts.xml |
Reviewed. |
docs/xml/Android.App.AppSearch/AppSearchSchema+PropertyConfig.xml |
Reviewed. |
docs/xml/Android.App.Admin/WipeDataFlags.xml |
Reviewed. |
docs/xml/Android.App.Admin/WifiSsidPolicy.xml |
Reviewed. |
docs/xml/Android.App.Admin/UserManagementFlags.xml |
Reviewed. |
docs/xml/Android.App.Admin/UnsafeStateException.xml |
Reviewed. |
docs/xml/Android.App.Admin/TargetUser.xml |
Reviewed. |
docs/xml/Android.App.Admin/ResetPasswordFlags.xml |
Reviewed. |
docs/xml/Android.App.Admin/PreferentialNetworkServiceConfig+Builder.xml |
Reviewed. |
docs/xml/Android.App.Admin/PolicyUpdateResult.xml |
Reviewed. |
docs/xml/Android.App.Admin/ManagedSubscriptionsPolicy.xml |
Reviewed. |
docs/xml/Android.App.Admin/KeyguardDisable.xml |
Reviewed. |
docs/xml/Android.App.Admin/FactoryResetProtectionPolicy.xml |
Reviewed. |
docs/xml/Android.App.Admin/DevicePolicyResources.xml |
nit (1 vote): Preserve the escaped closing list-item tags in the summary. |
docs/xml/Android.Animation/ValueAnimator.xml |
Reviewed. |
docs/xml/Android.Animation/TypeConverter.xml |
nit (1 vote): Change used convert to used to convert. |
docs/xml/Android.Animation/StateListAnimator.xml |
Reviewed. |
docs/xml/Android.Animation/ITypeEvaluator.xml |
Reviewed. |
docs/xml/Android.Animation/BidirectionalTypeConverter.xml |
nit (1 vote): Change used convert to used to convert. |
docs/xml/Android.Accounts/AbstractAccountAuthenticator.xml |
Reviewed. |
docs/xml/Android.AccessibilityServices/GlobalAction.xml |
Reviewed. |
docs/xml/Android.AccessibilityServices/AccessibilityService+SoftKeyboardController+IOnShowModeChangedListener.xml |
Reviewed. |
docs/xml/Android.AccessibilityServices/AccessibilityService+MagnificationController+IOnMagnificationChangedListener.xml |
Reviewed. |
Review details
Suppressed comments (3)
docs/xml/Android.Animation/BidirectionalTypeConverter.xml:35
- The imported summary is missing
toinused convert, which makes the public documentation ungrammatical. Change it toused to convert.
docs/xml/Android.Animation/TypeConverter.xml:35 - The imported summary is missing
toinused convert, which makes the public documentation ungrammatical. Change it toused to convert.
docs/xml/Android.App.Admin/DevicePolicyResources.xml:166 - These escaped HTML list items lose their closing
</li>tags in the summary, even though the unchanged remarks retain them. That produces malformed list markup in the rendered documentation; preserve the closing tags here.
- Files reviewed: 161/3797 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Preserve existing availability metadata for supported API levels and remove generated whitespace-only changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve pre-existing obsoletion metadata so this update contains only API 37.2-specific documentation changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
## Summary Discovered at: - dotnet/android-api-docs#680 - dotnet/android-api-docs#681 - build the mdoc framework-root path with `System.IO.Path.DirectorySeparatorChar` - keep the quoted `mdoc update` path valid on Windows by addressing the same directory as `docs-gen-temp\.` ## Root cause `_RunMdoc` passed `$(BaseIntermediateOutputPath)docs-gen-temp/` to `mdoc.exe fx-bootstrap`. On Windows, mdoc enumerates framework child directories with backslashes while retaining the root's trailing `/`. Its substring calculation then drops the first character of the framework moniker (`net-android-*` becomes `et-android-*`) and fails with a missing-path error. Independent Android 37.1 and Android 37.2 documentation-generation runs reproduced the same failure. Using a native trailing backslash fixes `fx-bootstrap`. The full target also requires avoiding a quoted argument that ends immediately in `\`, so `mdoc update` receives the equivalent `docs-gen-temp\.` path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restore base XML serialization for retained documentation and remove the unrelated KeyType attribute overlap. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Rename the API 37.2 framework inventory to the .NET 11 product moniker net-android-37.0 while retaining android37.2 platform availability metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
## Summary - update generated obsoletion metadata on retained Android APIs to match current `dotnet/android` binding output - replace API 22-24 `ObsoletedOSPlatform` attributes with the generator's unconditional `Obsolete` fallback - remove coupled `SupportedOSPlatform` markers at or below the product minimum where emitted on the same retained nodes - exclude Android 37.1/37.2 API additions, platform markers, documentation churn, formatting changes, and unrelated generated metadata ## Provenance and semantics This is the coherent shared attribute delta originally visible in #680 and #681, applied independently to `dotnet/android-api-docs` main at exact base `35e55643e8ae52652c141630a1014de717fdd060`. Both source regenerations used `dotnet/android` parent `261d2ce4894cb33942179f113f723eb6ec22f011`. That source includes dotnet/android#12682, which wires `--minimum-api-level=24` from `$(AndroidMinimumDotNetApiLevel)` into the Java.Interop generator. The generator intentionally emits plain `Obsolete` for APIs deprecated at or below the product minimum, preserving exact deprecation messages and enum-constant `error=true` flags. The upstream change includes generator tests and API-compatibility baselines for this behavior. The diagnostic becomes unconditional (`CS0618`) rather than platform-conditional (`CA1422`), but that semantic change is intentional in the current binding metadata because .NET for Android no longer supports platforms below API 24. ## Exact attribute delta - 853 retained DocIds: 407 types and 446 members - `ObsoletedOSPlatform` -> `Obsolete`: 853 - Android 22: 520 - Android 23: 222 - Android 24: 111 - coupled `SupportedOSPlatform` removals at/below API 24: 18 - enum-constant fallbacks preserving `error=true`: 49 - 479 modified XML files, 1,706 insertions, 1,778 deletions ## Final overlap checks Checked against the moniker-corrected narrowed heads: - #680 at `aea4f412748bb98a5b3c14e91bb9315c7b5102e5`: 11 shared filenames, zero overlapping attribute DocIds, clean merge tree - #681 at `fb55cd7de510783dc504d3ad7ab119e3b24cc131`: 23 shared filenames, zero overlapping attribute DocIds, clean merge tree The shared filenames contain independent API-level changes; there is no semantic attribute overlap with either narrowed PR. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Address review feedback in newly imported Android documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Revalidate the API 37.2 documentation after net-android-37.0 was registered with Learn. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
Reviewed the complete 712-file revision 0be09ccf7e979119d91e01bd1a2f4c71cfc82e77 against base/merge base ad971efe1b070db06daf8973f4808208db5d0117, including all changed owners, native-to-managed coverage, older-product inventories, metadata, and consumer behavior.
The accepted .NET 11 product moniker net-android-37.0 and native 37.2/37.1 distinction are preserved, and current publishing checks pass. Five current-base correctness/preservation findings remain. The complete affected-owner manifests and locations below distinguish genuine new regressions from resolved prior findings, unchanged baseline omissions, and nonblocking formatting.
Findings
1. Restore XML still required by older product inventories
Severity: High
The PR deletes one type and 18 members that remain referenced by unchanged net-android-34.0, 35.0, or 36.0 inventories. This introduces 25 broken historical inventory references.
Removing these APIs from the new .NET 11 inventory may be correct. Deleting their shared XML is not: the publisher reads the current XML tree and uses the inventories to assign monikers; inventories do not contain replacement documentation bodies.
Fix: retain the historical XML owners and appropriate older metadata while excluding them from the new product inventory where required. Do not restore removed APIs to the .NET 11 inventory merely to repair historical publication.
Complete deletion manifest
Paths are repository-absolute. Lines identify the deleted owners in the exact base.
| File | Deleted owner | Base line | Required older products |
|---|---|---|---|
| /docs/xml/Android.App.PermissionUI/LocationButtonSession.xml | T:Android.App.PermissionUI.LocationButtonSession |
1 | 36 |
| Same file | TextTypeNearMyPreciseLocation field |
33 | 36 |
| Same file | TextTypeNearYourPreciseLocation field |
66 | 36 |
| Same file | TextTypeNone field |
99 | 36 |
| Same file | TextTypePreciseLocation field |
132 | 36 |
| Same file | TextTypeSharePreciseLocation field |
165 | 36 |
| Same file | TextTypeUsePreciseLocation field |
198 | 36 |
| /docs/xml/Android.Graphics.Pdf.Component/PdfPagePathObject.xml | SetFillColor(System.Int32) |
627 | 36 |
| Same file | SetStrokeColor(System.Int32) |
674 | 36 |
| /docs/xml/Android.Graphics.Pdf.Component/PdfPageTextObject.xml | SetFillColor(System.Int32) |
723 | 36 |
| Same file | SetStrokeColor(System.Int32) |
769 | 36 |
| /docs/xml/Android.Hardware.Camera2.Params/OutputConfiguration.xml | SetPhysicalCameraId(System.String) |
1763 | 34, 35, 36 |
| /docs/xml/Android.Telecom/CallControl.xml | Answer(Android.Telecom.CallType, Java.Util.Concurrent.IExecutor, Android.OS.IOutcomeReceiver) |
856 | 34, 35 |
| Same file | RequestVideoState(Android.Telecom.CallType, Java.Util.Concurrent.IExecutor, Android.OS.IOutcomeReceiver) |
922 | 35 |
| /docs/xml/Android/Manifest+Permission.xml | UseLoopbackInterface field |
11650 | 36 |
| /docs/xml/Java.Interop/JniRuntime+JniTypeManager.xml | TryRegisterNativeMembers(Java.Interop.JniType, System.Type, System.ReadOnlySpan{System.Char}) |
719 | 34, 35 |
| Same file | TryRegisterNativeMembers(Java.Interop.JniType, System.Type, System.String) |
760 | 34, 35 |
| /docs/xml/Java.Interop/JniRuntime+JniValueManager.xml | ActivatePeer(Java.Interop.IJavaPeerable, Java.Interop.JniObjectReference, System.Reflection.ConstructorInfo, System.Object[]) |
1313 | 34, 35 |
| Same file | TryConstructPeer(Java.Interop.IJavaPeerable, Java.Interop.JniObjectReference@, Java.Interop.JniObjectReferenceOptions, System.Type) |
1277 | 36 |
All 19 owners existed in the base XML and are absent from the full head XML. None is referenced by the new net-android-37.0 inventory. The other 70 missing historical inventory references were already missing in the base and are not attributed to this PR.
2. Restore meaningful documentation replaced by generated debris or truncation
Severity: High
The PR replaces 43 meaningful summaries with { or slash-only separator text. It also truncates the UnicodeSet.SpanCondition summary and loses a valid parameter description during a parameter rename.
Valid XML and successful publication do not protect against this loss. The unchanged remarks in several owners still contain the meaningful contract, but that does not repair corrupted API summaries.
Fix: preserve the verified base descriptions or correct the narrowly identified generation/import failures. Restore the parameter description under its new declared name.
Complete slash-only summary manifest
Every row below affects both DescribeContents() and
WriteToParcel(Android.OS.Parcel, Android.OS.ParcelableWriteFlags).
File under /docs/xml/Android.Service.Autofill/ |
DescribeContents line |
WriteToParcel line |
|---|---|---|
| BatchUpdates.xml | 128 | 309 |
| CharSequenceTransformation.xml | 140 | 327 |
| CustomDescription.xml | 160 | 347 |
| Dataset.xml | 181 | 368 |
| DateTransformation.xml | 174 | 355 |
| DateValueSanitizer.xml | 170 | 351 |
| FillResponse.xml | 122 | 467 |
| ImageTransformation.xml | 139 | 326 |
| LuhnChecksumValidator.xml | 178 | 365 |
| RegexValidator.xml | 174 | 361 |
| SaveInfo.xml | 210 | 701 |
| TextValueSanitizer.xml | 175 | 356 |
| UserData.xml | 129 | 658 |
| VisibilitySetterAction.xml | 123 | 288 |
The remaining slash-only summaries are:
| File | Owner | Current line |
|---|---|---|
| /docs/xml/Android.Text/Layout.xml | IsFallbackLineSpacingEnabled |
2957 |
| /docs/xml/Android.Views.Autofill/AutofillValue.xml | DescribeContents() |
167 |
| Same file | WriteToParcel(Android.OS.Parcel, Android.OS.ParcelableWriteFlags) |
915 |
| /docs/xml/Org.Xml.Sax.Ext/Attributes2Impl.xml | IsDeclared(System.Int32) |
214 |
Complete brace-only summary manifest
| File | Owner | Current line |
|---|---|---|
| /docs/xml/Java.Time.Format/TextStyle.xml | AsStandalone() |
128 |
| /docs/xml/Java.Util/Objects.xml | Compare(Java.Lang.Object, Java.Lang.Object, Java.Util.IComparator) |
463 |
| Same file | DeepEquals(Java.Lang.Object, Java.Lang.Object) |
521 |
| Same file | Equals(Java.Lang.Object, Java.Lang.Object) |
581 |
| Same file | HashCode(Java.Lang.Object) |
688 |
| Same file | IsNull(Java.Lang.Object) |
739 |
| Same file | NonNull(Java.Lang.Object) |
822 |
| Same file | RequireNonNullElse(Java.Lang.Object, Java.Lang.Object) |
1086 |
| Same file | RequireNonNullElseGet(Java.Lang.Object, Java.Util.Functions.ISupplier) |
1149 |
| Same file | ToString(Java.Lang.Object) |
1310 |
| Same file | ToString(Java.Lang.Object, System.String) |
1363 |
TextStyle.AsStandalone() also gains a stray trailing } in its return description.
Two additional preservation failures:
| File | Owner/channel | Current line | Regression |
|---|---|---|---|
| /docs/xml/Android.Icu.Text/UnicodeSet+SpanCondition.xml | Type summary | 29 | Ends at “contained vs.”, dropping the distinguishing “not contained in the set” clause |
| /docs/xml/Java.Time.Zone/ZoneOffsetTransition.xml | CompareTo(ZoneOffsetTransition), parameter |
102 | Declared parameter changes from transition to otherTransition, but its meaningful description becomes To be added. |
The other 49 parameter-tag loss candidates were classified as orphan/property-setter parameter tags rather than valid declared-parameter regressions; 17 retained their text in another channel. They are not included in this blocker.
3. Preserve correct member contracts instead of importing misassigned source comments
Severity: Medium
The following six owners receive incorrect or mismatched documentation. These are substantive contract changes, not grammar preferences.
| File and current location | Owner | Verified problem and correction |
|---|---|---|
| /docs/xml/Android.Telephony.Mbms/DownloadRequest.xml:292 | MaxAppIntentSize |
Describes the destination URI instead of the app’s serialized completion intent. Builder.setAppIntent() checks the Intent.toUri() string against MAX_APP_INTENT_SIZE. |
| Same file, line 336 | MaxDestinationUriSize |
Describes the completion intent instead of the destination URI. The two summaries are swapped. |
| /docs/xml/Android.Systems/StructStatVfs.xml:233 | FBsize |
Adds “used for block counts.” statvfs block counts use f_frsize units, not f_bsize. |
| /docs/xml/Javax.Xml.Datatype/DatatypeFactory.xml:1027 | NewInstance() return |
Claims DocumentBuilderFactory, while the managed return and JNI descriptor are DatatypeFactory. |
/docs/xml/Javax.Xml.Parsers/SAXParserFactory.xml:128–131 |
GetFeature(System.String) |
Parameter, summary, and return text describe a property; the method returns a Boolean feature flag. The summary is additionally truncated at org. |
| /docs/xml/Android.Widget/TextView.xml:110 | .ctor(Android.Content.Context) |
Receives the zygote font-cache description belonging to the separate static preloadFontCache() method, not the constructor. |
Some incorrect text also exists in upstream source comments. That does not make the resulting member contract correct: the MBMS implementation, JNI/managed return types, statvfs contract, and actual TextView method association independently establish the mismatch.
Fix: retain the correct base documentation or apply narrowly source/implementation-verified corrections, without broad generation changes.
4. Preserve historical version-specific metadata
Severity: Medium
Three metadata changes overwrite information still needed by older product monikers.
| Current file/location | Owner | Lost historical metadata |
|---|---|---|
/docs/xml/Android.Security.Identity/IdentityCredentialStore.xml:141–142 |
CiphersuiteEcdheHkdfEcdsaWithAes256GcmSha256 |
Removes System.Obsolete(..., true) and substitutes only ObsoletedOSPlatform("android37.2", ...). The field remains in products 34, 35, and 36. |
/docs/xml/Android.Security/NetworkSecurityPolicy.xml:164–165 |
DomainEncryptionModeOpportunistic |
Same replacement; the field remains in product 36. |
| /docs/xml/Java.Interop/JavaTypeParametersAttribute.xml:18 | Type-forwarding chain | Replaces ToVersion="99.61.0.0" with 11.0.0.0 without framework scoping, changing the historical product-36 forwarding result. |
The forwarding issue was reduced against the inspected consumer logic. For net-android-36.0, the base resolves the defining assembly to Java.Interop, 99.61.0.0; the head leaves both that assembly and the Mono.Android facade because the new forwarding target no longer matches the older framework version.
Fix: preserve older obsoletion and forwarding metadata with appropriate framework-specific entries while retaining legitimate .NET 11/native-37.2 metadata. These XML changes do not alter the compiled Android binaries; the issue is incorrect published product metadata.
5. Correct the two-argument Activity F# signature
Severity: Medium
Location: Activity.xml:10604
ShouldShowRequestPermissionRationale(System.String, System.Int32) changes its F# declaration to only:
override this.ShouldShowRequestPermissionRationale : string * int -> boolIts C# declaration remains public virtual, and IL remains newslot virtual. The pinned native/current managed ancestor chain introduces only the one-argument overload on Context; no ancestor supplies the two-argument method to override.
Fix: restore the F# declaration consistent with this method’s own virtual slot. Keep the legitimate one-argument override transition introduced by the new Context API.
Restore historical inventory XML, meaningful documentation, version-scoped metadata, and the correct F# virtual signature identified during review. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@dalexsoto All five findings from your review of
The latest-main conflict resolution also preserves 37.2 API shape/inventory while accepting newer main documentation. Validation: all 11,079 XML files parse, zero duplicate DocIds, 10,697 unique 37.0 inventory types, 135,578 unique inventory members, zero exact inventory duplicates, and Please re-review when ready. |
dalexsoto
left a comment
There was a problem hiding this comment.
Re-reviewed the complete 499-file revision bc6f318e1e6c65a244d5dc4d728a2c441d9d743d against the new base b867947703edcaece3c2a055ae6ea01847cae68f. All five submitted groups are fixed: the 19 historical owners and 25 inventory memberships are restored; all 43 summaries and the additional documentation/contract corrections are verified; historical obsoletion and forwarding metadata project correctly by product; and the Activity F# virtual-slot signature is consistent. The merge preserves genuine 37.2 APIs, the current inventory, and newer-main documentation. No high-confidence correctness blockers remain within the accepted scope.
Update generated API documentation to match the Android.AgentIcon namespace introduced by dotnet/android#12815. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Updated the generated API 37.2 docs to use @dalexsoto, could you please rereview? |
dalexsoto
left a comment
There was a problem hiding this comment.
Re-reviewed the complete 499-file revision 8bc91f25b7e6092da3ae9a2c28197263000b4c4c against base b867947703edcaece3c2a055ae6ea01847cae68f. The sixteen-file Android.AgentIcon namespace update preserves API content and all 282 existing placeholders, leaves Java/JNI names unchanged, and maintains inventory closure. Independent metadata inspection of both actual reference and runtime CI packages confirms the corrected type definitions/mapping, StatusBarManager references, and all four enumified ParcelableWriteFlags signatures. The five previously fixed finding groups remain intact.
No new high-confidence documentation blocker remains within the stated conditional scope. The existing prerequisite still applies: dotnet/android#12815 must merge before this documentation update. That PR remains open; its artifact-producing build's package-test failure has not been cleared or classified as harmless by this review. This documentation approval is not a dependency merge-readiness verdict or authorization to merge either PR.
Summary
net-android-37.0android37.2Android.AgentIconnamespace from [Mono.Android] Fix AgentIcon namespace casing android#12815, including framework inventory, namespace mapping, cross-namespace signatures, and generated enum signaturesScope
b867947703edcaece3c2a055ae6ea01847cae68fdocs/xml/FrameworksIndex/net-android-37.0.xmlwith<Framework Name="net-android-37.0">FrameworkAlternateuses the Android SDK minor version; retainednet-android-36.0alternates remain historical .NET 10 metadataAgentIcon dependency
The latest commit assumes dotnet/android#12815 merges before this documentation update. It changes only the managed namespace token and paths from
Android.AgenticontoAndroid.AgentIcon; after reversing that token, all 16 touched files are byte-identical to their prior content (with checkout line endings normalized).The actual unsigned packages from Azure DevOps build 1601030, source merge commit
9bc18c75acd8945015e14e460f067a75f32ec20f, were independently inspected:Microsoft.Android.Ref.37.2.37.2.0-ci.pr.gh12815.0.nupkg(SHA256 E59D0C92E32D5A9E14CEBF7A72CD1BE4CDD839D7D0C25464A9C83C9C1F23AA46)Microsoft.Android.Runtime.37.2.android.37.2.0-ci.pr.gh12815.0.nupkg(SHA256 7F05BEDA55BE709A78AF163A91EF5C98F38A3CB2218146883CDB0E29D7D0AE95)Both
Mono.Android.dllassemblies contain the four expected top-levelAndroid.AgentIcontypes and their nested builders/interface constants, zero exactAndroid.Agenticondefinitions or references, theandroid.agenticonJava namespace mapping,StatusBarManagerreferences toAndroid.AgentIcon, and all four enumifiedWriteToParcel(..., Android.OS.ParcelableWriteFlags)signatures.Validation
Android.Agenticonor the incorrectnet-android-37.2.0monikerandroid.agenticontoAndroid.AgentIconnamespace mappingandroid37.2git diff --checkpassesLearn moniker
net-android-37.0is centrally registered with Learn. For future Android documentation monikers, use OPS Monikers, select Request-Monikers, and use platformDotnet; see the Learn moniker help. The .NET Android API Docs Publishing runbook names Dave Britch as the contact.Generated from dotnet/android parent
261d2ce4894cb33942179f113f723eb6ec22f011, with the AgentIcon namespace output validated against dotnet/android#12815 CI binaries.