Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build-tools/automation/azure-pipelines-internal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ variables:
extends:
template: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates
parameters:
settings:
networkIsolationPolicy: Permissive,CFSClean
pool:
name: $(NetCoreInternalPoolName)
image: $(WindowsPoolImageNetCoreInternal)
Expand Down
1 change: 1 addition & 0 deletions build-tools/automation/azure-pipelines.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ extends:
suppression:
suppressionFile: $(Build.SourcesDirectory)\.gdn\.gdnsuppress
settings:
networkIsolationPolicy: Permissive,CFSClean
Comment thread
jonathanpeppers marked this conversation as resolved.
Resolved
skipBuildTagsForGitHubPullRequests: true
stages:
- template: /build-tools/automation/yaml-templates/build-macos.yaml@self
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ internal static (IReadOnlyList<SdkPackage> Installed, IReadOnlyList<SdkPackage>
var trimmed = line.Trim ();

// Match section headers case-insensitively: the classic sdkmanager emits
// "Available Packages:" (capital P) while the newer Android CLI replacement
// "Available Packages:" (uppercase P) while the newer Android CLI replacement

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a PoliCheck warning, but ugh I wanted this a separate PR and copilot put it here.

Just a comment, but it's fine, I guess.

// (cmdline-tools 23+) emits "Available packages:" (lowercase p).
var foundSection = false;
foreach (var section in PackageSections) {
Expand Down
Loading