Repository navigation
[ci] Enable CFSClean network isolation - #12643
Merged
Merged
Conversation
Explicitly compose CFSClean with Permissive and the existing CFSClean2/CFSClean3 policies for the shared production and PR pipeline definition. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the network isolation policy in the pipeline's existing settings map so Azure template expansion accepts it. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
List only Permissive and CFSClean in repository YAML so CFSClean2 and CFSClean3 continue to come from PerPipelineRequiredConfig. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, targeted pipeline configuration update and matches existing usage of networkIsolationPolicy in the repo with no correctness issues found.
Pull request overview
This PR updates the shared 1ES pipeline entrypoint to explicitly enable the CFSClean network isolation policy (while retaining Permissive) for the Xamarin.Android production and PR Azure DevOps definitions that extend this template.
Changes:
- Add
settings.networkIsolationPolicy: Permissive,CFSCleanto the sharedbuild-tools/automation/azure-pipelines.yamlpipeline configuration.
File summaries
| File | Description |
|---|---|
| build-tools/automation/azure-pipelines.yaml | Explicitly sets the 1ES networkIsolationPolicy to include CFSClean while keeping Permissive. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Apply Permissive and CFSClean at the dnceng/internal 1ES settings boundary while retaining centrally required CFSClean2 and CFSClean3. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use uppercase terminology in the sdkmanager parsing comment while preserving its meaning. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
commented
Sep 2, 2026
|
|
||
| // Match section headers case-insensitively: the classic sdkmanager emits | ||
| // "Available Packages:" (capital P) while the newer Android CLI replacement | ||
| // "Available Packages:" (uppercase P) while the newer Android CLI replacement |
Member
Author
There was a problem hiding this comment.
This is a PoliCheck warning, but ugh I wanted this a separate PR and copilot put it here.
Just a comment, but it's fine, I guess.
Member
Author
|
@dalexsoto review |
simonrozsival
approved these changes
Sep 2, 2026
jonathanpeppers
added a commit
that referenced
this pull request
Sep 4, 2026
## Summary Backports the complete CFSClean/network-isolation set needed by `release/10.0.1xx`: - #10803 / `1e4bbd9c501098d18c2306d74c2117b725553f8b` — update `mono/debugger-libs` to remove its nested `api.nuget.org` override and use the approved `dotnet-tools` feed - #12520 / `7c7d207aa8b73eb8e733a9269c5d7e131587096b` — route Roslyn analyzer test reference acquisition through the repository `NuGet.config` - #12643 / `8eac8ed475d33470319e8ced1040e866c9f01467` — enable `networkIsolationPolicy: Permissive,CFSClean` in the shared DevDiv production/PR pipeline - #12544 / `adb7d10d80907604727cd415fbb184a33fd0e3d2` — route Xamarin.Build.Download Google Maven requests through `dotnet-public-maven`, update XBD to 0.11.6, and directly pin the transitive test consumer The commits remain separate and in dependency order. ## Release compatibility The #12643 cherry-pick produced modify/delete conflicts for two main-only files that do not exist on this release branch: - `build-tools/automation/azure-pipelines-internal.yaml` - `src/Xamarin.Android.Tools.AndroidSdk/SdkManager.Packages.cs` Both paths remain absent. The first would invent dnceng/internal topology not used by this release branch; the second upstream change was comment-only. The release-applicable shared `build-tools/automation/azure-pipelines.yaml` policy change was retained unchanged. `CFSClean2` and `CFSClean3` are intentionally not listed because they are supplied centrally by `PerPipelineRequiredConfig`. Retaining `Permissive` allows required Android SDK/NDK traffic; DefaultDeny Google SDK/NDK telemetry is not a failure for this change. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networkIsolationPolicy: Permissive,CFSCleanin the shared DevDiv production/PR pipeline entry pointPermissiveso Android SDK/NDK traffic remains availableCFSClean2andCFSClean3instead of listing them in repository YAMLcapital Pwithuppercase Pin an sdkmanager parsing comment to avoid a PoliCheck geopolitical false positive without changing behaviorPipeline coverage
11410— Xamarin.Androidbuild-tools/automation/azure-pipelines.yaml12278— Xamarin.Android-PRbuild-tools/automation/azure-pipelines.yaml1644— dotnet-android-internalbuild-tools/automation/azure-pipelines-internal.yamlThe dnceng/internal definition is independent of the DevDiv definitions, so both YAML entry points require an explicit setting.
dotnet-android-tools-official(1596) belongs to the separatedotnet-android-toolsrepository and is not in scope. Public, nightly, API-docs, and Renovate definitions are also unchanged.This PR is opened from a branch in the main
dotnet/androidrepository so trusted/full definitions can validate the submitted commit. The earlier fork PR was closed.SFI / CFS rationale
S360 tracks Xamarin.Android (
devdiv/11410) and Xamarin.Android-PR (devdiv/12278). Directapi.nuget.orgaccess is classified as aCFSCleanviolation. This change applies the policy without weakening it or adding a public-NuGet allowlist.Validation evidence
Final commit:
b63ae9fd6.The pipeline validation builds below ran against implementation commit
2cc30f604c5742141d9cccff57311614362e99c2; the final commit changes only comment wording to resolve the resulting PoliCheck false positive.PermissiveandCFSCleancame fromPipelineArguments;CFSClean2andCFSClean3came fromPerPipelineRequiredConfig. Windows Android preparation succeeded. The run reached a 20-minute Mac .NET timeout after its build/tests had otherwise succeeded; its PoliCheck failure is addressed by the final comment-only commit.Prepare Solutiondownloaded 15 Android archives fromdl.google.com, includingandroid-ndk-r28c-windows.zip, and completed successfully with no network-isolation block. Its PoliCheck failure is addressed by the final comment-only commit.make jenkinsactively built native Android targets with the cached SDK CMake and NDK Clang toolchain with no network-isolation or acquisition errors.Expanded
Start Network Isolationlogs for all three definitions report:Policies=[(Permissive:PipelineArguments), (CFSClean:PipelineArguments), ... (CFSClean2:PerPipelineRequiredConfig), (CFSClean3:PerPipelineRequiredConfig)]The policy composition and required Android dependency acquisition checks pass; the final comment-only fix removes the observed PoliCheck false positive.