Handle the correct zero-value

[greg0ire]

It was changed in 3e2fad5, I am not sure why, I think it might be to avoid the extra conditions / complexity I'm adding here. What I know is that it makes a guard condition in FileDriver::initialize() useless, most likely resulting in persistence looking for a file with a name consisting only in an extension (.php, .yml…).

persistence/src/Persistence/Mapping/Driver/FileDriver.php

Lines 173 to 191 in 267cd9f

	protected function initialize()
	{
	$this->classCache = [];
	if ($this->globalBasename === null) {
	return;
	}
	foreach ($this->locator->getPaths() as $path) {
	$file = $path . '/' . $this->globalBasename . $this->locator->getFileExtension();
	if (! is_file($file)) {
	continue;
	}
	$this->classCache = array_merge(
	$this->classCache,
	$this->loadMappingFile($file)
	);
	}
	}

[derrabus]

Can we produce a test that fails without your change?

[greg0ire]

Can we produce a test that fails without your change?

Not a very meaningful one I'm afraid. It would assert that a file named literally .php doesn't get loaded even if it exists. I don't think such a scenario should be tested, and I think this guard condition is here for performance only (it spares a call to is_file()).