Drop support for PHP < 8.1 #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
php81
branch
3 times, most recently
from
826f9d5 to
061c10a
Compare
derrabus
reviewed
May 21, 2024
SenseException
previously approved these changes
May 21, 2024
derrabus
reviewed
May 21, 2024
| { | ||
| $this->classCache = []; | ||
| if ($this->globalBasename === null) { | ||
| if ($this->globalBasename === '') { |
Member
There was a problem hiding this comment.
Is this a bugfix? Do we need to fix this on 3.x?
Member
There was a problem hiding this comment.
It would make sense to add this to 3.x. I haven't seen a way to set this property to null.
Member
Author
There was a problem hiding this comment.
Ah yes I did it then forgot about it. See #362
SenseException
approved these changes
May 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.