Skip to content

[19.03 backport] Makefile changes and Bump Go 1.12.9 #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
docker-unir merged 7 commits into from
Sep 25, 2019
Merged

[19.03 backport] Makefile changes and Bump Go 1.12.9 #380

docker-unir merged 7 commits into from
Sep 25, 2019

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 16, 2019 •
edited
Loading

Backports of:

Related PRs:

thaJeztah and others added 7 commits September 16, 2019 16:40
@thaJeztah
Revert "FIX pathing issue with cli dir"
41debaf 
This reverts commit a1419a7.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@zelahi @thaJeztah
FIXED retrieving GO_VERSION from the CLI dir
0ca225a 
Signed-off-by: zelahi <[email protected]>
(cherry picked from commit 5f1afbb)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@zelahi @thaJeztah
FIX pathing issue with cli dir
524b348 
(cherry picked from commit 0df1091)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Makefile: set STATIC_VERSION only if empty
7789c00 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 3b8cc28)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Makefile: use include for common variables
14beb36 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit fe23576)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Makefile: realpath engine-, cli-dir
c621124 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 2929c9b)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@tao12345666333 @thaJeztah
Bump Golang 1.12.9
a67e30e 
Signed-off-by: Jintao Zhang <[email protected]>
(cherry picked from commit cc3b9fb)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah changed the title [19.03 backport] Makefile changes and Bump Go 1.12.9 [WIP][19.03 backport] Makefile changes and Bump Go 1.12.9 Sep 16, 2019
@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 16, 2019

marked as "WIP", because #377 has not yet been merged

@thaJeztah thaJeztah changed the title [WIP][19.03 backport] Makefile changes and Bump Go 1.12.9 [19.03 backport] Makefile changes and Bump Go 1.12.9 Sep 23, 2019
andrewhsu
andrewhsu approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 19.03.3 milestone Sep 24, 2019
@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 24, 2019

ping @seemethere @zelahi PTAL

@docker-unir docker-unir bot merged commit 21096e8 into docker:19.03 Sep 25, 2019
@thaJeztah thaJeztah deleted the 19.03_backport_bump_go_1.12.9 branch September 25, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

@seemethere seemethere seemethere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

19.03.3

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah @andrewhsu @seemethere @zelahi @tao12345666333