Makefile: use an include file for common variables #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the assumption that;
cd static && make <foo>)make static-> recurses over the makefiles)make GO_VERSION=1.13beta1 static)Tricky bits:
CLI_DIRandENGINE_DIRin thecommon.mk(because it's done relative to the working directory).realpath(docs says it returns an empty path if it's not found, so we could first try../engineand if it's empty, try../../engine)GO_VERSION; this is a bit unclear: why doesstatic/Makefiledetect the Go-version from the CLI, but other targets don't?GO_VERSIONbe set to the CLI's version for all targets?latest?STATIC_VERSION(see first commit)I noticed that static version was always overridden (?), which meant that static packages would potentially get a different version than non-static versions if called from the main Makefile (
make static)? (TBH; just from reading the code, haven't verified if they did)