Add support for generic resources to bash completion #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 218 218
Lines 14613 14613
=======================================
Hits 7811 7811
Misses 6321 6321
Partials 481 481 |
thaJeztah
approved these changes
Dec 14, 2017
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
one nit, but LGTM otherwise
| --dns-search-rm | ||
| --group-add | ||
| --group-rm | ||
| --generic-resource-add |
Member
There was a problem hiding this comment.
Do you want to keep this alphabetical? If so, it should be above the --group-... lines 🤗
Collaborator
Author
There was a problem hiding this comment.
The alphabet is really comlicated...
Thanks for catching. PR is updated.
Adds bash completion for - `service create --generic-resource` - `service update --generic-resource-(add|rm)` - `dockerd --node-generic-resource` Signed-off-by: Harald Albers <[email protected]>
albers
force-pushed
the
completion--generic-resource
branch
from
3373a60 to
8ec80ee
Compare
Member
|
😄 thanks! merging, so that I can cherry-pick |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
Add support for generic resources to bash completion Upstream-commit: 8684b99 Component: cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bash completion for #429:
service create --generic-resourceservice update --generic-resource-(add|rm)dockerd --node-generic-resource