This repository was archived by the owner on Oct 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[17.12] backport docs and completion #358
Merged
seemethere
merged 4 commits into
docker-archive:17.12
from
thaJeztah:17.12-backport-docs-and-completion
Dec 19, 2017
Merged
[17.12] backport docs and completion #358
seemethere
merged 4 commits into
docker-archive:17.12
from
thaJeztah:17.12-backport-docs-and-completion
Dec 19, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit ddadd3db494ce568a6b847932677f837802ea6b5 refactored the markdown documentation, but accidentally changed `on-failure` to `failure`. This patch corrects this change. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 43217d733205b0694f791e7326bfed6d13b645f0) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Kotaro Yoshimatsu <[email protected]> (cherry picked from commit db05d8ad79e34e8096f31585fe9ffe0ce18f98d8) Signed-off-by: Sebastiaan van Stijn <[email protected]>
mdlinville
approved these changes
Dec 15, 2017
Adds bash completion for - `service create --generic-resource` - `service update --generic-resource-(add|rm)` - `dockerd --node-generic-resource` Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit 8ec80eec672b93be03843412f195fae477e81c4a) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
Added docker/cli#749 |
Contributor
|
@thaJeztah It would be really nice to have these in here as well: docker/cli#717, docker/cli#713, docker/cli#682. They've been hanging around for quite a while. |
Signed-off-by: Harald Albers <[email protected]> (cherry picked from commit a2d0b6e122021cfac87a99a46d3d02339552d281) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
Added docker/cli#713 - I'll try to add more 👍 |
Contributor
|
Thanks!
|
mdlinville
approved these changes
Dec 18, 2017
seemethere
approved these changes
Dec 19, 2017
Contributor
seemethere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docker-jenkins
pushed a commit
that referenced
this pull request
Jul 6, 2019
Merged with https://github.com/seemethere/unir Upstream-commit: bdcef5cf2259c9aab6d4e5196c357174fcdf83c1 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Sep 20, 2019
[19.03 backport] Send exec exit event on failures Upstream-commit: 879fba29d54b4403bb11cc69fa0ba9b6b4aca7c2 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 24, 2020
…ocs-and-completion [17.12] backport docs and completion
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 27, 2020
…ocs-and-completion [17.12] backport docs and completion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks for 17.12 of:
no conflicts
ping @MistyHacks @andrewhsu PTAL