Plumb contexts through commands #4700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
thaJeztah
force-pushed
the
wire_up_contexts
branch
from
2883fcb to
6e1f7ff
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4700 +/- ##
==========================================
- Coverage 59.68% 59.66% -0.02%
==========================================
Files 287 287
Lines 24865 24760 -105
==========================================
- Hits 14841 14774 -67
+ Misses 9138 9100 -38
Partials 886 886 |
thaJeztah
commented
Dec 6, 2023
cli/command/container/stats.go
Outdated
Comment on lines
130
to
131
| span := trace.SpanFromContext(ctx) | ||
|
|
Member
Author
There was a problem hiding this comment.
DOH! Looks like some OTEL changes landed in the wrong commit; let me fix that;
13 7.030 ERROR: Vendor result differs. Please vendor your package with "make -f docker.Makefile vendor"
6e1f7ff to
ae83009
Compare
thaJeztah
force-pushed
the
wire_up_contexts
branch
3 times, most recently
from
84ecac1 to
4074b49
Compare
thaJeztah
commented
Dec 12, 2023
thaJeztah
force-pushed
the
wire_up_contexts
branch
from
4074b49 to
f4869c2
Compare
This is to prepare for otel support. Signed-off-by: Brian Goff <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
wire_up_contexts
branch
from
f4869c2 to
5400a48
Compare
vvoland
approved these changes
Dec 13, 2023
laurazard
approved these changes
Dec 13, 2023
| // baseCtx is the base context used for internal operations. In the future | ||
| // this may be replaced by explicitly passing a context to functions that | ||
| // need it. | ||
| baseCtx context.Context |
Collaborator
There was a problem hiding this comment.
Should keep an eye on this and see if we can factor it out later 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prepare for otel support.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)