Skip to content

Conversation

@cpuguy83
Copy link
Collaborator

@cpuguy83 cpuguy83 commented Sep 9, 2023

This is broken into 2 commits:

  • Plumb contexts through commands
  • Add otel tracing as a persistent pre-run to all CLI commands.

@cpuguy83 cpuguy83 force-pushed the otel branch 3 times, most recently from 2f9b0db to 3bfa506 Compare September 10, 2023 15:54
This is to prepare for otel support.

Signed-off-by: Brian Goff <[email protected]>
@cpuguy83 cpuguy83 force-pushed the otel branch 4 times, most recently from db2f196 to 7eb3218 Compare September 10, 2023 17:16
Signed-off-by: Brian Goff <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #4556 (d4511b0) into master (d4aca90) will decrease coverage by 0.10%.
Report is 528 commits behind head on master.
The diff coverage is 62.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4556      +/-   ##
==========================================
- Coverage   59.66%   59.57%   -0.10%     
==========================================
  Files         288      288              
  Lines       24785    24740      -45     
==========================================
- Hits        14789    14739      -50     
- Misses       9111     9112       +1     
- Partials      885      889       +4     

@thaJeztah
Copy link
Member

/cc @milas as well (just a "FYI", but perhaps there's input from your side to make this align with compose's OTEL integration)

Comment on lines +50 to +53
require (
go.opentelemetry.io/otel v1.4.1
go.opentelemetry.io/otel/trace v1.4.1
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ended up in the wrong block

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 ☁️

@cpuguy83
Copy link
Collaborator Author

Just a heads up, this is causing docker build to slow down quite a bit which I need to look into.

@thaJeztah
Copy link
Member

I did a rebase of this branch (and fixed some OTEL changes that were in the wrong commit 😂). Looks like OTEL itself is still causing some headaches, so I split the changes in 2 PRs;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants