Skip to content

fix(ChannelManager): Remove threads from cache upon deletion #10883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

fix(ChannelManager): Remove threads from cache upon deletion #10883

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbdb217
fix(ChannelManager): remove threads from cache upon deletion
Jiralite May 4, 2025
4f352de
refactor: loop over thread ids
Jiralite May 7, 2025
0f43272
Merge branch 'main' into fix/trailing-thread-cache
kodiakhq[bot] May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/discord.js/src/managers/ChannelManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,15 @@ class ChannelManager extends CachedManager {

channel?.parent?.threads?.cache.delete(id);
this.cache.delete(id);

if (channel?.threads) {
for (const cacheChannelId of this.cache.keys()) {
if (channel.threads.cache.has(cacheChannelId)) {
this.cache.delete(cacheChannelId);
channel.guild?.channels.cache.delete(cacheChannelId);
}
}
}
}

/**
Expand Down